Upgrade to helm 3.3.4

[mcfedr]

Description

Upgrade to helm 3.3

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

References

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[mcfedr]

i see the tests are failing but this seems to be an issue for all PRs at the moment

[js-timbirkett]

I think that they're failing due to the upstream terraform-website tests failing. Maybe remove website tests for now?

[js-timbirkett]

@jrhouston @dak1n1 - Hi John and Stef 👋

I don't normally reach out directly to maintainers like this but this PR (or rather the bugs in earlier Kubernetes and Helm versions) is a blocker for deploying some Helm charts like cert-manager v1.0.1. I saw that you were able to help with the last Helm dependency upgrade and hoped you might be able to help out in getting this PR reviewed and progressed?

Thanks, Tim.

[horjulf]

3.3.2 was released today.

https://github.com/helm/helm/releases/tag/v3.3.2

[mcfedr]

Updated the dependency to 3.3.2

[andyspiers]

@js-timbirkett @mcfedr - i've opened a complimentary PR #590 which fixes the website tests, hopefully if that gets merged it will enable the acceptance tests to run for this PR

[sam-cogan]

Can this be made a priority to get merged? It is blocking some deployment of some fairly critical helm charts

[mcfedr]

make testacc - https://gist.github.com/mcfedr/64376294e3f583d77147edb2d888e42f

[aareet]

Thanks for keeping this PR updated - we are planning to push a helm upgrade as a part of some other changes, that's why the wait. Appreciate your patience!

[sennerholm]

The #590 (website tests) is now merged, is it worth to rerun the tests to see if it's getting green? Or is that colliding with the big plan @aareet ?

/Another user really want this is in a released version of the provider

[mcfedr]

@sennerholm Just rebased on master so maybe the tests will show as green now

[sebglon]

LGTM

[jrhouston]

Thanks for taking care of this @mcfedr!

Thanks for waiting everyone. 🚀

[sleenen]

Happy this is merged, can we expect a new release to go with this too?

[sennerholm]

@sleenen , I don't know if you have seen it yet, but https://github.com/hashicorp/terraform-provider-helm/releases contains part of a 1.3.1 release and

terraform providers mirror ~/.terraform.d/plugins
- Mirroring hashicorp/helm...
  - Selected v1.3.1 to meet constraints ~> 1.3
  - Downloading package for darwin_amd64...
  - Package authenticated: signed by HashiCorp

[sleenen]

thank you @sennerholm ! I have seen it, tried it right away, everything working like a charm (needed this for installing cert-manager latest version, which required higher helm version)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!