Fix website tests #590
Merged
Fix website tests #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdown linting and link checking, closely based on hashicorp/terraform-provider-kubernetes#989
only triggers on changes to website/ path no need to run >5min code tests for markdown changes
andyspiers
force-pushed
the
fix-docs-tests
branch
from
3a66f85 to
9ff378d
Compare
|
@dak1n1 This can unlock all other PR CI. |
aareet
approved these changes
Sep 24, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test suite for terraform-provider-helm has been failing since the provider was migrated to the terraform registry in this commit hashicorp/terraform-website@da8a3fa (reason: removal of helm-related symlinks causes helm docs to be ignored by the
terraform-websitecontainer and the test suite here to fail)This is impeding new PRs being accepted on terraform-provider-helm because unit tests fail and hence acceptance tests don't run.
Implementation
This PR replaces the old
website-testandwebsitemake targets withwebsite-lintwebsite-lintis heavily based on hashicorp/terraform-provider-kubernetes#989 which solved this same problem for terraform-provider-kubernetesInstead of spinning up a middleman-hashicorp container from https://github.com/hashicorp/terraform-website it uses other open-source, containerised tools to:
Finally, rather than running
website-lintalong with the unit tests and acceptance tests, it splits them out to a separate Github action which triggers when changes are made to the website path, thus saving a 5-10 min acceptance test suite run for changes which only affect the docs.References
This is complementary to #566
It will hopefully help other PRs like #560 and #572 and make their tests start passing
Community Note