Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout and retry to framework version of provider #149

Closed
1 task done
bendbennett opened this issue Jun 30, 2022 · 1 comment · Fixed by #151
Closed
1 task done

Add timeout and retry to framework version of provider #149

bendbennett opened this issue Jun 30, 2022 · 1 comment · Fixed by #151
Assignees
@bendbennett
Labels
enhancement
Milestone
v3.3.0

Comments

@bendbennett
Copy link
Contributor

Terraform CLI and Provider Versions

v1.2.2

Use Cases or Problem Statement

The http provider is being migrated to the Terraform Plugin Framework.

There are outstanding pull requests and issues that have addressed or requested, respectively that timeouts and retries be implemented for HTTP requests. Specifically:

Proposal

This PR will incorporate pull requests and issues that have addressed or requested, respectively that timeouts and retries be implemented for HTTP requests.

Closes: #87
Closes: #71
Closes: #49

How much impact is this issue causing?

Low

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bendbennett bendbennett added this to the v3.1.0 milestone Jun 30, 2022
bendbennett added a commit that referenced this issue Jul 1, 2022
@bendbennett
Adding optional request_timeout attribute (#149)
6574d72
bendbennett added a commit that referenced this issue Jul 1, 2022
@bendbennett
Adding optional retry.attempts attribute (#149)
b0cdfab
bendbennett added a commit that referenced this issue Jul 1, 2022
@bendbennett
Updating CHANGELOG.md and docs (#149)
9659ad3
@bendbennett bendbennett mentioned this issue Jul 1, 2022
Merged
bendbennett added a commit that referenced this issue Jul 1, 2022
@bendbennett
Removing unneeded URL pathname (#149)
072499c
bendbennett added a commit that referenced this issue Jul 1, 2022
@bendbennett
Simplifying check to avoid out of bounds panic (#149)
a5bf5ad
bendbennett added a commit that referenced this issue Jul 5, 2022
@bendbennett
Adding optional request_timeout attribute (#149)
e1f8d05
bendbennett added a commit that referenced this issue Jul 5, 2022
@bendbennett
Adding optional retry.attempts attribute (#149)
a4bf148
bendbennett added a commit that referenced this issue Jul 5, 2022
@bendbennett
Updating CHANGELOG.md and docs (#149)
d83b69e
bendbennett added a commit that referenced this issue Jul 5, 2022
@bendbennett
Removing unneeded URL pathname (#149)
9341233
bendbennett added a commit that referenced this issue Jul 5, 2022
@bendbennett
Simplifying check to avoid out of bounds panic (#149)
76679ed
bendbennett added a commit that referenced this issue Jul 5, 2022
@bendbennett
Refactoring provider (#149)
c7cebe4
bendbennett added a commit that referenced this issue Jul 5, 2022
@bendbennett
Adding optional request_timeout attribute (#149)
e974f5a 
Adding optional retry.attempts attribute (#149)
@bendbennett bendbennett modified the milestones: v3.1.0, v3.2.0 Aug 22, 2022
@bendbennett bendbennett removed this from the v3.2.0 milestone Oct 27, 2022
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Adding optional request_timeout attribute (#149)
8a90650 
Adding optional retry.attempts attribute (#149)
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Rebasing and fixing (#149)
95d759a
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Switching to using block to maintain compatibility with protocol vers…
aa99c0d 
…ion 5 (#149)
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Using parallel tests where allowed and refactoring to use an httptest…
057da83 
… server per test (#149)
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Regenerating docs (#149)
abe608f
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Changing retry wording (#149)
74aaad5
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Using cloned transport in retryClient (#149)
ee6b971
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Setting timeout on retryclient http client (#149)
627dc13
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Adding min and max delay for retry (#149)
6f95f1f
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Update docs (#149)
4bb03a0
bendbennett added a commit that referenced this issue Feb 3, 2023
@bendbennett
Removing measurement of time interval between requests when max_delay…
4c2277d 
… is set (#149)
bendbennett added a commit that referenced this issue Feb 6, 2023
@bendbennett
Only set min and/or max delay between retries if value set in config …
f79a9aa 
…and the value is >= 0 (#149)
bendbennett added a commit that referenced this issue Feb 9, 2023
@bendbennett @Vince-Chenal
Adding optional request_timeout and retry attributes (#149)
593fe98 
Co-authored-by: Vincent Chenal <vincent.chenal@protonmail.com>
bendbennett added a commit that referenced this issue Feb 9, 2023
@bendbennett @Vince-Chenal
Adding optional request_timeout and retry attributes (#149)
1c016ee 
Co-authored-by: Vincent Chenal <vincent.chenal@protonmail.com>
bendbennett added a commit that referenced this issue Feb 9, 2023
@bendbennett @Vince-Chenal
Adding optional request_timeout and retry attributes (#149)
3ff90d2 
Co-authored-by: Vincent Chenal <vincent.chenal@protonmail.com>
bendbennett added a commit that referenced this issue Apr 6, 2023
@bendbennett @Vince-Chenal
Adding optional request_timeout and retry attributes (#149)
936b3c8 
Co-authored-by: Vincent Chenal <vincent.chenal@protonmail.com>
bendbennett added a commit that referenced this issue Apr 6, 2023
@bendbennett
Fixing ExpectError in tests (#149)
4d22215
bendbennett added a commit that referenced this issue Apr 6, 2023
@bendbennett
Fixing ExpectError in tests (#149)
ccc248e
bendbennett added a commit that referenced this issue Apr 11, 2023
@bendbennett
Updates following code review (#149)
bfd1df5
@bflad bflad added this to the v3.3.0 milestone Apr 11, 2023
bendbennett added a commit that referenced this issue Apr 12, 2023
@bendbennett @Vince-Chenal
Add timeout and retry to framework version of provider (#151)
ae33628 
* Adding optional request_timeout and retry attributes (#149)

Co-authored-by: Vincent Chenal <vincent.chenal@protonmail.com>

* Fixing ExpectError in tests (#149)

* Updates following code review (#149)

---------

Co-authored-by: Vincent Chenal <vincent.chenal@protonmail.com>
@alekc alekc mentioned this issue Apr 18, 2023
Open
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bendbennett bendbennett

Labels
enhancement
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging a pull request may close this issue.

Add timeout and retry to framework version of provider hashicorp/terraform-provider-http
2 participants
@bflad @bendbennett