Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional timeout to client #71

Closed

Conversation

jamesgoodhouse
Copy link

This adds a new argument called timeout to allow setting of the client timeout.

@daroga0002
Copy link

daroga0002 commented May 12, 2021

any progress in this?

@kmoe @bflad

@jamesgoodhouse
Copy link
Author

I'm confused, looks like this was merged in somehow, but not from this branch... ?

@barryib
Copy link

barryib commented May 22, 2021

@jamesgoodhouse I merged your PR in a fork I made for terraform-aws-modules internal usage.

You can find it here terraform-aws-modules#4.

Thanks for your work.

Your PR here should remain open untill it get merge.

@daroga0002
Copy link

@kmoe @bflad could you take a look?

@arianvp
Copy link

arianvp commented Oct 8, 2021

Any chance to get this merged? The diff seems completely trivial and correct to me

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@bendbennett bendbennett self-assigned this Jun 13, 2022
@bendbennett bendbennett added this to the v3.1.0 milestone Jul 1, 2022
@bendbennett bendbennett modified the milestones: v3.1.0, v3.2.0 Aug 22, 2022
@bendbennett bendbennett removed this from the v3.2.0 milestone Oct 27, 2022
@bflad bflad added this to the v3.3.0 milestone Apr 18, 2023
@bflad
Copy link
Contributor

bflad commented Apr 18, 2023

Hi @jamesgoodhouse 👋 Thank you for this submission and apologies for the delayed review. This appears to have been covered by #151 which required a different approach, but has recently been merged and will release with version 3.3.0 in the near future. I'm going to close this out as there does not appear to be anything actionable left to do with this pull request.

@bflad bflad closed this Apr 18, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants