-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add optional timeout to client #71
Conversation
I'm confused, looks like this was merged in somehow, but not from this branch... ? |
@jamesgoodhouse I merged your PR in a fork I made for terraform-aws-modules internal usage. You can find it here terraform-aws-modules#4. Thanks for your work. Your PR here should remain open untill it get merge. |
Any chance to get this merged? The diff seems completely trivial and correct to me |
Hi @jamesgoodhouse 👋 Thank you for this submission and apologies for the delayed review. This appears to have been covered by #151 which required a different approach, but has recently been merged and will release with version 3.3.0 in the near future. I'm going to close this out as there does not appear to be anything actionable left to do with this pull request. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This adds a new argument called
timeout
to allow setting of the client timeout.