fix broken links #1041
Merged
fix broken links #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
|
aareet
suggested changes
Jan 26, 2021
dak1n1
reviewed
May 5, 2021
There was a problem hiding this comment.
Thanks for cleaning up these docs! I saw you caught some typos too, which is great.
I rebased off this branch and ran the link check script, and all your changes have successfully fixed the problems. I'll open another PR to apply the link check script to our CI, now that it's all cleaned up. Thanks!
| @@ -158,7 +158,7 @@ The following arguments are supported: | |||
| * `priority_class_name` - (Optional) If specified, indicates the pod's priority. 'system-node-critical' and 'system-cluster-critical' are two special keywords which indicate the highest priorities with the formerer being the highest priority. Any other name must be defined by creating a PriorityClass object with that name. If not specified, the pod priority will be default or zero if there is no default. | |||
| * `restart_policy` - (Optional) Restart policy for all containers within the pod. One of Always, OnFailure, Never. For more info see [Kubernetes reference](http://kubernetes.io/docs/user-guide/pod-states#restartpolicy). | |||
| * `security_context` - (Optional) SecurityContext holds pod-level security attributes and common container settings. Optional: Defaults to empty | |||
| * `service_account_name` - (Optional) ServiceAccountName is the name of the ServiceAccount to use to run this pod. For more info see http://releases.k8s.io/HEAD/docs/design/service_accounts.md. | |||
| * `service_account_name` - (Optional) ServiceAccountName is the name of the ServiceAccount to use to run this pod. For more info see https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/. | |||
There was a problem hiding this comment.
Same suggestion as with pod, since this is for a podSpec:
Suggested change
| * `service_account_name` - (Optional) ServiceAccountName is the name of the ServiceAccount to use to run this pod. For more info see https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/. | |
| * `service_account_name` - (Optional) ServiceAccountName is the name of the ServiceAccount to use to run this pod. For more info see https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/. |
dak1n1
pushed a commit
to dak1n1/terraform-provider-kubernetes
that referenced
this pull request
May 10, 2021
Update links to Kubernetes docs and examples.
dak1n1
added a commit
that referenced
this pull request
May 13, 2021
* Use `go install` instead of tools.go Previously, we were using tools.go to keep go.mod from changing during package installations. That is no longer needed. This will help to clean up incompatible licenses. #1238 * Docs: fix broken links (#1041) Update links to Kubernetes docs and examples. * Enable links check and fix 2 links (#1259) Co-authored-by: Neha Viswanathan <12013126+neha-viswanathan@users.noreply.github.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #990
To be merged after #1027