Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable links check and fix 2 links #1259

Merged
merged 1 commit into from
May 7, 2021
Merged

Conversation

dak1n1
Copy link
Contributor

@dak1n1 dak1n1 commented May 7, 2021

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@dak1n1 dak1n1 merged commit 0dfb1f0 into hashicorp:main May 7, 2021
dak1n1 added a commit to dak1n1/terraform-provider-kubernetes that referenced this pull request May 10, 2021
dak1n1 added a commit that referenced this pull request May 13, 2021
* Use `go install` instead of tools.go

Previously, we were using tools.go to keep go.mod from changing during package installations. That is no longer needed.
This will help to clean up incompatible licenses. #1238

* Docs: fix broken links (#1041)

Update links to Kubernetes docs and examples.

* Enable links check and fix 2 links (#1259)


Co-authored-by: Neha Viswanathan <12013126+neha-viswanathan@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants