Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14-rc1 and Terraform Cloud, plan with no changes still expecting to create resources #26899

Closed
jurgenweber opened this issue Nov 12, 2020 · 4 comments · Fixed by #26944
Closed
Labels
bug confirmed a Terraform Core team member has reproduced this issue v0.14 Issues (primarily bugs) reported against v0.14 releases

Comments

@jurgenweber
Copy link

Terraform Version

Terraform v0.14.0-rc1
+ provider instaclustr/instaclustr/instaclustr v1.6.1
+ provider registry.terraform.io/hashicorp/aws v3.14.1
+ provider registry.terraform.io/hashicorp/helm v1.3.2
+ provider registry.terraform.io/hashicorp/kubernetes v1.13.3
+ provider registry.terraform.io/hashicorp/local v1.4.0
+ provider registry.terraform.io/hashicorp/null v2.1.2
+ provider registry.terraform.io/hashicorp/random v3.0.0
+ provider registry.terraform.io/hashicorp/template v2.2.0
+ provider registry.terraform.io/hashicorp/tfe v0.22.0

Terraform Configuration Files

...

Debug Output

Crash Output

Expected Behavior

When there are no changes, terraform should report:

No changes. Infrastructure is up-to-date.

This means that Terraform did not detect any differences between your
configuration and real physical resources that exist. As a result, no
actions need to be performed.

Actual Behavior

Terraform reports:

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:

Terraform will perform the following actions:

Plan: 0 to add, 0 to change, 0 to destroy.

Steps to Reproduce

  1. go into terraform cloud and queue another run

Additional Context

I have had this issue for a long time, in v0.13, the AWS provider v3+ had a lot of problems with data sources and non deterministic ID's, etc that made sort of sudo changes. This has all been cleaned up and in v0.13.... it works now... But ude to some other errors I had to move to v0.14 and now this behaviour is back.

References

@jurgenweber jurgenweber added bug new new issue not yet triaged labels Nov 12, 2020
@jbardin
Copy link
Member

jbardin commented Nov 13, 2020

Hi @jurgenweber

I suspect there is a still a data source involved here which is not behaving correctly. If the data source has no visible side-effects but is still deferred until apply, it might cause this behavior. Can you provide a configuration which reproduces this issue?

We may also be able to figure out what is triggering the the change from trace logs when applying this plan.

Thanks!

@jbardin jbardin added waiting for reproduction unable to reproduce issue without further information waiting-response An issue/pull request is waiting for a response from the community and removed new new issue not yet triaged labels Nov 13, 2020
@jurgenweber
Copy link
Author

jurgenweber commented Nov 15, 2020

Ok, my code base is pretty big so I can not really give you the whole lot. Here is a list of the current used data sources:

aws_ami
aws_availability_zones
aws_caller_identity
aws_eks_cluster
aws_eks_cluster_auth
aws_iam_instance_profile
aws_iam_policy
aws_iam_policy_document
aws_iam_role
aws_kms_key
aws_kms_secrets
aws_lb
aws_organizations_organization
aws_partition
aws_route53_zone
aws_s3_bucket
aws_subnet
aws_vpc_endpoint
aws_vpc_endpoint_service
datasync_endpoint_private_dns_enabled
datasync_endpoint_security_group_ids
datasync_endpoint_subnet_ids
enable_datasync_endpoint
kubernetes_service
template_file
terraform_remote_state

what I am looking for in the trace? I have not been able to find anything useful so far.

I can see a bit of this though:

2020-11-15T23:28:07.911Z [WARN]  plugin.stdio: received EOF, stopping recv loop: err="rpc error: code = Unavailable desc = transport is closing"

@ghost ghost removed waiting-response An issue/pull request is waiting for a response from the community labels Nov 15, 2020
@jurgenweber
Copy link
Author

if I could get some direction on what to look for, hopefully we can pin it down?

@jbardin jbardin added confirmed a Terraform Core team member has reproduced this issue and removed waiting for reproduction unable to reproduce issue without further information labels Nov 17, 2020
@pselle pselle added the v0.14 Issues (primarily bugs) reported against v0.14 releases label Nov 17, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug confirmed a Terraform Core team member has reproduced this issue v0.14 Issues (primarily bugs) reported against v0.14 releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants