Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Don't render a plan for module outputs into v0.14 #26948

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #26944 to be assessed for backporting due to the inclusion of the label 0.14-backport.

The below text is copied from the body of the original PR.


Module outputs should not trigger plan rendering. These are not shown in the plan output, however they were still causing Changes.Empty() to return false.

Fixes #26899

@teamterraform teamterraform force-pushed the backport/jbardin/module-output-plan/smoothly-quality-killdeer branch from f6bc192 to d44c931 Compare November 17, 2020 21:36
@jbardin jbardin requested review from a team and removed request for jbardin November 17, 2020 21:37
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #26948 (d44c931) into v0.14 (de1574d) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
plans/changes.go 0.80% <0.00%> (+0.80%) ⬆️
terraform/node_resource_plan.go 95.32% <0.00%> (-1.87%) ⬇️
terraform/eval_apply.go 73.45% <0.00%> (+0.58%) ⬆️
backend/local/backend_plan.go 71.08% <0.00%> (+2.40%) ⬆️

@jbardin jbardin merged commit 1c36729 into v0.14 Nov 17, 2020
@jbardin jbardin deleted the backport/jbardin/module-output-plan/smoothly-quality-killdeer branch November 17, 2020 21:53
@ghost
Copy link

ghost commented Dec 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants