Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't render a plan for module outputs #26944

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Don't render a plan for module outputs #26944

merged 2 commits into from
Nov 17, 2020

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Nov 17, 2020

Module outputs should not trigger plan rendering. These are not shown in the plan output, however they were still causing Changes.Empty() to return false.

Fixes #26899

@jbardin
don't render plan for module outputs
5f4ff0e 
Module outputs should not trigger plan rendering.
@jbardin jbardin added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Nov 17, 2020
@jbardin jbardin requested a review from a team November 17, 2020 14:34
@codecov
Copy link

codecov bot commented Nov 17, 2020 •
edited
Loading

Codecov Report

Merging #26944 (8e7a9b6) into master (79fd817) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
plans/changes.go 0.80% <0.00%> (+0.80%) ⬆️
dag/marshal.go 53.42% <0.00%> (-1.37%) ⬇️
backend/local/backend_plan.go 71.08% <0.00%> (+2.40%) ⬆️

pselle
pselle reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@pselle pselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This covers the changes test, but we're (and were) missing a test that tests the UI output in this case ... could you add something for that?

@jbardin
output test for plan with no root output changes
8e7a9b6 
Module outputs do not show up in the plan, and are not rendered in the
UI.
@jbardin
Copy link
Member Author

jbardin commented Nov 17, 2020

Sounds good to me! Added a test to show there's no output.

@jbardin jbardin merged commit b06db96 into master Nov 17, 2020
@jbardin jbardin deleted the jbardin/module-output-plan branch November 17, 2020 21:35
@teamterraform teamterraform mentioned this pull request Nov 17, 2020
Merged
@ghost
Copy link

ghost commented Dec 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pselle pselle pselle approved these changes

Assignees
No one assigned
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.14-rc1 and Terraform Cloud, plan with no changes still expecting to create resources
2 participants
@jbardin @pselle