Add helpers.shema.Provisoner base type for provisioners like there's one for providers

[VladRassokhin]

Migrate provisioners to providers-like hierarchy when all of then extends schema.Provisioner.
Built-in plugins were migrated.
Also added support for schema validation for built-in provisioners: file, local-exec, remote-exec.

AFAIU external plugins would still compile but functions Apply and Validate from schema.Provisioner would not be used, so change is quite safe. Tried that by reverting cahnges in 'chef' provisioner in separate commit

[mitchellh]

Thanks this is a great start, but I'm not ready to merge as-is. I believe we should have the provisioners use the ResourceData structure similar to Providers, for easy config access.

I might be willing to make these changes since we need to support the Stop API in core for provisioners (just doesn't yet) to make them interruptable... and I wanted to make that easy by having a helper/schema-type thing.

[VladRassokhin]

Hi @mitchellh
Thanks for fast feedback.
I've updated PR with your suggestion.

As mentioned in commit message:
Known problems:

• had to introduce ResourceData.GetRawConfig() since chef provisioner parses configuration manually;
• In remote-exec provisioner inline can no longer accept 'string' value, only list of strings allowed. - due to migration to schema. There's a workaround like it;s done in chef provisioner, but I'd like to keep code as is.

So test failure is expected,

[VladRassokhin]

If you think it's worth to spend time, I'd try to convert chef provisioner to use Schema and get rid of ResourceData.GetRawConfig()

[VladRassokhin]

Hi @mitchellh, could you please take a look and provide some feedback? Maybe that PR could be merged before 0.8?

[mitchellh]

Hey @VladRassokhin, thanks for this! I'm sorry to pre-empt your work but in introducing a Stop API for provisioners I ended up doing this in #10934. Thanks for your work and I'm sorry I didn't get this merged prior. :(

[VladRassokhin]

Ok, fine. At least provisioners now has schema so I could rebase #3508 to use it and it would simplify generating metadata for IntelliJ plugin.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.