Use helpers.shema.Provisoner in chef provisioner
#12033
Conversation
|
@mitchellh Please take a look. I've rebased my branch after your changes in provisioners |
1. Migrate `chef` provisioner to `schema.Provisioner`: * `chef.Provisioner` structure was renamed to `ProvisionerS`and now it's decoded from `schema.ResourceData` instead of `terraform.ResourceConfig` using simple copy-paste-based solution; * Added simple schema without any validation yet. 2. Support `ValidateFunc` validate function : implemented in `file` and `chef` provisioners.
|
@paddycarver @mitchellh Sorry for disturbing but could anyone merge/comment on this PR ❓ |
|
@VladRassokhin I will review this one, but it will take a few more days until I am behind a desk again (and this PR is a bit too big to review on my phone 😉) So unless someone else steps in, I'll make sure to make some time for this one in the coming week. |
|
@VladRassokhin I spent a reasonable amount of time on this one today... I started with a normal review, but it soon became a challenge to mark and explain my findings/concerns. So I thought the fasted way forward was to created a new branch based on your work and add a single commit tweaking what was (IMO) needed to get this ready to be merged. Overall I didn't really change any fundamental stuff. There was one real issue with the schema (with the fields that contained an So thank you very much for all your work and my apologies for the initial leak of response! I'll be closing this PR as soon as the new one is merged (which will hopefully be today). |
|
OK, so I'm going to close this one right away as I need an additional So to not cause any confusion with these almost similar PR's, I'll close this one and refer you to the new PR #14681. Thanks again!! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Also
ValidateFuncintroduced for extended provisioner data validation.This PR is rebase of #10422 on top of master after #10934 being merged.