Block Device Support for Autoscaling Launch Configurations #1271

jwaldrip · 2015-03-21T03:47:09Z

No description provided.

tomchapin · 2015-03-25T15:23:58Z

👍

phinze · 2015-03-30T14:32:21Z

This is looking really good!

I think the last iteration we need before landing this is to pull it in line with the reworking of block devices that landed in master. #1045

I looked into the BlockDeviceMappings AWS docs and it seems like the behavior is going to be exactly the same across instances and LCs, which means that LCs will benefit just as much from having the split resources of root_block_device, ebs_block_device, and ephemeral_block_device.

I think a lot of the code over in instance.go will be able to be reused. (We can start by duplicating before we try and factor common stuff up.)

If this all sounds super scary to you, let us know and one of our contributors can try to pick it up.

Thanks again for all the work on this! 😀

jwaldrip · 2015-03-30T21:01:59Z

builtin/providers/aws/resource_aws_launch_configuration.go

+
+func readBlockDevicesFromLaunchConfiguration(d *schema.ResourceData, launchConfiguration *autoscaling.LaunchConfiguration, autoscalingconn *autoscaling.AutoScaling) map[string]interface{} {
+	var blockDevices = make(map[string]interface{})
+	// Need to figure out how to determine the various instance types.


@phinze, I mimic'd the write functionality of the EC2 Block instances. How do I determine whether a device is root, ephemeral, or ebs on the read?

@jwaldrip I'm recommending pretty much copying the schema from instances and the block device handling code. I think it should translate pretty decently to the LC APIs.

I believe I already did that. But there is a read section that I don't exactly know how to follow.

Oh! Sorry @jwaldrip I definitely responded without catching that there were new commits. 🙈

Let me take a look!

Okay, this is super rough and probably won't compile, I think it could look something like this: https://gist.github.com/phinze/01f6163bf452eee289d5

Basically, checking the DeviceName against the RootDeviceName of the AMI, leaning on a helper living over in resource_aws_instance.go to grab it for us.

jwaldrip · 2015-03-30T22:27:20Z

Should be good to go. But I will let you all be the judge.

phinze · 2015-03-30T22:33:31Z

builtin/providers/aws/resource_aws_launch_configuration.go

+				Type:     schema.TypeMap,
+				Optional: true,
+				Removed:  "Split out into three sub-types; see Changelog and Docs",
+			},


No need to reproduce the deprecation warning here since we never supported it in the first place.

@phinze Should I just pull out block device all together? Since it alone was never supported in the first place?

phinze · 2015-03-30T22:35:27Z

Nice! Almost there - just a couple of tweaks I mentioned.

Thanks for all your work on this! 🙇

delianides · 2015-03-31T14:20:21Z

Nice work on this. I was playing around with this myself but you beat me to the PR. 👍

phinze · 2015-04-01T23:31:19Z

@jwaldrip - Would love to get this in for 0.4 (which we cut tomorrow) - let me know if you can't get to the final tweaks and I can pick'em up myself. 👍

jwaldrip · 2015-04-02T14:17:03Z

working on it right now.

phinze · 2015-04-02T14:30:39Z

Cool! Keep me posted. 🙆‍♀️

jwaldrip · 2015-04-02T15:11:17Z

Should be good to go!

jwaldrip · 2015-04-02T15:26:28Z

@phinze think it will get into the release?

phinze · 2015-04-02T15:28:24Z

Nice! Yep this will make it in.

LGTM - I'll give the acc. tests a quick run and then merge. 👍

Great work on this!

pmoust · 2015-04-02T15:31:32Z

Great! would be nice to squash this into a single commit as well.

phinze · 2015-04-02T15:32:09Z

+1 @jwaldrip can you squash?

jwaldrip · 2015-04-02T15:48:05Z

@phinze squashed!

pmoust · 2015-04-02T16:14:28Z

@jwaldrip terraform crashes if there is no block device information in plan. In our use case we were relying on AMIs defaults.

phinze · 2015-04-02T16:16:54Z

Yeah I'm rooting out several issues - here's my WIP so far: 6130d97

jwaldrip · 2015-04-02T16:19:03Z

@phinze I don't want to step on your toes if you are already fixing the issues. Or do you want me to jump on this as well?

phinze · 2015-04-02T16:20:32Z

@jwaldrip i think i might see the light at the end of the tunnel 😀 give me a few more minutes here and I'll let you know.

I'm curious, though, was everything working locally for you?

jwaldrip · 2015-04-02T16:22:15Z

I am checking again against my project.

jwaldrip · 2015-04-02T16:37:25Z

Yep. Panic'd ... my bad. I started rushing near the end there. How are things looking?

phinze · 2015-04-02T16:38:55Z

Looking good! Going to push a fresh PR with my tweaks so @pmoust can give us one more double check before merge.

phinze · 2015-04-02T16:41:30Z

Okay moving to #1364 to finish this out! 👌

ghost · 2020-05-03T02:27:49Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

jwaldrip mentioned this pull request Mar 21, 2015

terraform: add block_device support to resource_aws_launch_configuration #935

Closed

This was referenced Mar 30, 2015

provider/aws: aws_launch_configuration add device mapping option #1324

Closed

aws_launch_configuration: block_device support #756

Closed

jwaldrip reviewed Mar 30, 2015
View reviewed changes

phinze reviewed Mar 30, 2015
View reviewed changes

phinze added the waiting-response An issue/pull request is waiting for a response from the community label Apr 1, 2015

phinze removed the waiting-response An issue/pull request is waiting for a response from the community label Apr 2, 2015

block device support for launch configurations

341c325

jwaldrip changed the title ~~Block device mapping launch configuration (with resolved conflicts)~~ Block Device Support for Autoscaling Launch Configurations Apr 2, 2015

phinze mentioned this pull request Apr 2, 2015

block device support for launch configurations #1364

Merged

phinze closed this Apr 2, 2015

jwaldrip deleted the block-device-mapping-launch-configuration-resolve-conflicts branch April 8, 2015 16:03

ghost locked and limited conversation to collaborators May 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Block Device Support for Autoscaling Launch Configurations #1271

Block Device Support for Autoscaling Launch Configurations #1271

jwaldrip commented Mar 21, 2015

tomchapin commented Mar 25, 2015

phinze commented Mar 30, 2015

jwaldrip Mar 30, 2015

phinze Mar 30, 2015

jwaldrip Mar 30, 2015

phinze Mar 30, 2015

phinze Mar 30, 2015

jwaldrip commented Mar 30, 2015

phinze Mar 30, 2015

jwaldrip Apr 2, 2015

phinze Apr 2, 2015

phinze commented Mar 30, 2015

delianides commented Mar 31, 2015

phinze commented Apr 1, 2015

jwaldrip commented Apr 2, 2015

phinze commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

phinze commented Apr 2, 2015

pmoust commented Apr 2, 2015

phinze commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

pmoust commented Apr 2, 2015

phinze commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

phinze commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

phinze commented Apr 2, 2015

phinze commented Apr 2, 2015

ghost commented May 3, 2020

Block Device Support for Autoscaling Launch Configurations #1271

Block Device Support for Autoscaling Launch Configurations #1271

Conversation

jwaldrip commented Mar 21, 2015

tomchapin commented Mar 25, 2015

phinze commented Mar 30, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwaldrip commented Mar 30, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phinze commented Mar 30, 2015

delianides commented Mar 31, 2015

phinze commented Apr 1, 2015

jwaldrip commented Apr 2, 2015

phinze commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

phinze commented Apr 2, 2015

pmoust commented Apr 2, 2015

phinze commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

pmoust commented Apr 2, 2015

phinze commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

phinze commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

jwaldrip commented Apr 2, 2015

phinze commented Apr 2, 2015

phinze commented Apr 2, 2015

ghost commented May 3, 2020