Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: add block_device support to resource_aws_launch_configuration #935

Conversation

jschneiderhan
Copy link
Contributor

Adds the ability to define block_device entries on resource_aws_launch_configurations.

Note, this is dependent on an open PR in the mitchell/goamz repo mitchellh/goamz#210.

This should address #756.

@jschneiderhan jschneiderhan force-pushed the block-device-mapping-launch-configuration branch from 8ff874b to 0910c9b Compare February 5, 2015 20:29
@statik
Copy link

statik commented Feb 11, 2015

👍 Is there anything I can do to to help with this? I need block devices in autoscaling groups for a project and don't want to drop back to using CloudFormation instead of terraform.

@jschneiderhan
Copy link
Contributor Author

BTW most of the changes in this PR are copied over from the resource_aws_instance resource.

@jschneiderhan jschneiderhan changed the title DON'T MERGE: terraform: add block_device support to resource_aws_launch_configuration terraform: add block_device support to resource_aws_launch_configuration Mar 1, 2015
@jschneiderhan
Copy link
Contributor Author

mitchellh/goamz#210 was merged into master, so I'm removing the DON'T MERGE prefix of the PR title.

@jwaldrip
Copy link
Contributor

@statik agreed. Is there anything I can do to get this over the finishline?

@jwaldrip
Copy link
Contributor

Fixed merge conflicts, see: #1271

@jschneiderhan
Copy link
Contributor Author

Closing this - #1271 is the proper PR

@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants