adding exclude flag to plan and apply #2326
Conversation
|
Wow this is great work, @nevins-b - thank you! I think we can actually fold this into targeting, which will make the UX a bit more cohesive and the implementation simpler as well. My proposal is that we introduce a Then the implementation is basically just tacking your central loop onto the end of the TargetsTransformer. What do you think? |
|
@phinze Thanks! That seems reasonable. The parseTargetAddresses function will need to be modified but it shouldn't be too bad. |
regex solution is extremely complex, which makes it hard to debug and understand; the original switches and commenting lay out the various cases in a straightforward fashion. Plus, implementing namespace/repo support in the original code was a simple strings.Join call.
…rom map reverting changes, changing target to exclude when using ! cleanup
|
@nevins-b this sounds awesome! what's the next step here? is it just rebasing onto master? I also notice a lot of unrelated code in the diff. I think the only part that should be here is https://github.com/aocsolutions/terraform/commit/c7551d0bd9568aca48ec6eb10f1095029992f34b |
|
Any updates on this? |
|
Definitely want to land this! Closing this PR to roll into #3366 and will follow up there. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This will exclude the specified resource and it's dependents from the graph.
Addresses #2253