adding exclude flag to plan and apply to exclude specified resource from map #3366

josephholsten · 2015-09-30T06:17:39Z

Rebase of #2326

phinze · 2015-12-15T00:10:01Z

Hoping to take this for a spin this week. 👍

josephholsten · 2016-02-04T23:32:16Z

@phinze rebased this back onto master, let's see what the tests say

metcalfc · 2016-06-07T23:55:51Z

Any update here? This would really help me. I'm using remote_state to store the state of a bunch of shared infra (route53, etc) and when I run a terraform plan -destroy I'd love to exclude just the state the burn the rest down. If someone nukes the remote_state its 😢

holybit · 2016-09-19T22:46:03Z

👍 as I could use this feature for certain. Any progress?

carrete · 2016-11-04T15:44:55Z

👍 as I could use this feature for certain. Any progress?

Same.

dominik-lekse · 2017-05-03T10:11:02Z

Hi @phinze, @josephholsten, during developing infrastructure with Terraform this is a feature I currently miss. Besides a pending conflict resolution, is there anything preventing us to merge this functionality, i.e. the general idea/implementation of this feature?

josephholsten · 2017-06-11T20:38:49Z

well, I've rebased this but the tests are still failing. That's the next step.

josephholsten · 2017-06-11T22:01:49Z

command/plan.go

@@ -171,7 +171,8 @@ Options:

  -target=resource    Resource to target. Operation will be limited to this
                      resource and its dependencies. This flag can be used
-                      multiple times.
+                      multiple times. Prefixing the resource with ! will
+											exclude the resource.


josephholsten · 2017-06-11T22:02:22Z

terraform/transform_targets.go

-				log.Printf("[DEBUG] Removing %q, filtered by targeting.", dag.VertexName(v))
-				g.Remove(v)
+			if removable {
+				if targetedNodes.Len() > 0 && !targetedNodes.Include(v) {


targetedNodes.Len() > 0 breaks TestCloseProviderTransformer_withTargets

…rom map reverting changes, changing target to exclude when using ! cleanup

purkhusid · 2017-10-12T16:44:11Z

Any progress on this?

shantanugadgil · 2018-04-12T07:37:05Z

My use case is that there are some plan errors in an independent resource, and for the time being I want to just exclude it and see if everything else is fine.

stefanthorpe · 2018-04-27T06:16:48Z

This feature makes total sense to me. I have 2 modules that I want to exclude on destory, but 10+ that I want to include, obviously its best to exclude here than a massive long include.

rhodrid · 2018-06-13T13:28:27Z

I could really do with this feature right now

ghost · 2018-09-11T16:27:30Z

Is this still being worked on? My team could use the exclude flag for terraform plans that we're running nightly to monitor drift in our terraform repo.

We have a few items that are always going to be update in-place. It would be convenient to just exclude the things we expect to be like that from what's being monitored.

zoobab · 2018-10-12T08:00:51Z

Any update?

dbaumgarten · 2019-12-06T09:05:31Z

This PR has been open quite a while now. Are there any plans to complete it? It would be a super usefull feature.

shantanugadgil · 2019-12-06T10:18:00Z

4 years!!! Wow! terraform went from separate plugins to single binary and back to providers!☺️☺️☺️

bbetter173 · 2020-02-05T01:12:07Z

This ticket could have started school if it was a particularly gifted child.

ghost · 2020-02-07T03:11:18Z

Depends on the state. In North Carolina, I was 5 when I started school. I'm very surprised how long running this is.

sirlatrom · 2020-02-07T06:26:32Z

I'm going to unsubscribe due to this PR having been converted to a comedian school. I suggest anyone who finds it important creates a new PR rebased on master such that it can even be merged.

ghost · 2020-02-08T19:54:10Z

@apparentlymart are we still waiting on you to review this? Thelicense/cla check failed, who needs to do that agreement? Does @josephholsten need to agree to the contributor license agreement?

This feature would still be nice to have.

josephholsten · 2020-02-13T22:58:53Z

I've just submitted my CLA.

Omarimcblack · 2020-05-04T14:46:19Z

@josephholsten any chance you could fix the conflicts - would be cool to have this implemented.
@apparentlymart the related issue #2253 is ranked 2nd any chance you could also re-intervene

josephholsten · 2020-05-04T19:52:31Z

@Omarimcblack No, as you can see from this ticket's history, I have rebased this many times already. I didn't even write this code in the first place. @apparentlymart knows how to get ahold of me if hashicorp really wants this.

hashicorp-cla · 2020-06-08T02:35:20Z

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

JnMik · 2020-08-12T02:02:03Z

So @josephholsten , signing that CLA yet ? :D

josephholsten · 2020-08-14T05:06:16Z

Yes, I have signed previous versions of the CLA and I have signed this version. But I’m not the commit author.

jeffery · 2020-08-19T12:20:05Z

Only 6700 commits behind master. @nevins-b Are you around to help move this forward?

tjhiggins · 2020-09-29T19:07:41Z

@josephholsten could you submit a new pr so you can sign? Our team would find this incredibly useful.

Edit: I can also submit the pr if you'd prefer.

josephholsten · 2020-09-30T23:16:50Z

@tjhiggins

Yes, I have signed previous versions of the CLA and I have signed this version. But I’m not the commit author.

mildwonkey · 2020-10-01T20:45:43Z

hi! I am cleaning up some older PRs and am going to close this one. Please do chime in on the linked issue if you are still interested - we haven't forgotten this request, but it's going to take some careful design and isn't on our immediate roadmap. Thanks!

ghost · 2020-11-01T01:51:03Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

josephholsten mentioned this pull request Sep 30, 2015

adding exclude flag to plan and apply #2326

Closed

radeksimko added enhancement core labels Oct 3, 2015

apparentlymart mentioned this pull request Nov 12, 2015

prevent_destroy should let you succeed #3874

Open

phinze self-assigned this Dec 15, 2015

josephholsten force-pushed the excludes branch from b5718dd to b33cc53 Compare February 4, 2016 23:32

aarcro mentioned this pull request Jun 29, 2016

Resource Tagging #7414

Open

josephholsten force-pushed the excludes branch from b33cc53 to d33174f Compare June 11, 2017 20:36

josephholsten force-pushed the excludes branch from d33174f to eaafcad Compare June 11, 2017 21:19

josephholsten commented Jun 11, 2017

View reviewed changes

adding exclude flag to plan and apply to exclude specified resource f…

17eb5c4

…rom map reverting changes, changing target to exclude when using ! cleanup

josephholsten force-pushed the excludes branch from eaafcad to 17eb5c4 Compare June 11, 2017 22:11

apparentlymart self-requested a review June 12, 2017 22:18

phinze removed their assignment Oct 24, 2017

josephholsten mentioned this pull request Nov 14, 2017

feature request: inverse targeting / exclude #2253

Open

apparentlymart mentioned this pull request Apr 30, 2018

Until #3116 is finally fixed - -force_destroy flag ? -exclude some targets from plan ? #17915

Open

hashicorp deleted a comment from describeme Dec 21, 2019

hashicorp deleted a comment from anupkulkarni24 Dec 21, 2019

mildwonkey closed this Oct 1, 2020

ghost locked as resolved and limited conversation to collaborators Nov 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding exclude flag to plan and apply to exclude specified resource from map #3366

adding exclude flag to plan and apply to exclude specified resource from map #3366

josephholsten commented Sep 30, 2015

phinze commented Dec 15, 2015

josephholsten commented Feb 4, 2016

metcalfc commented Jun 7, 2016

holybit commented Sep 19, 2016

carrete commented Nov 4, 2016

dominik-lekse commented May 3, 2017

josephholsten commented Jun 11, 2017

josephholsten Jun 11, 2017

josephholsten Jun 11, 2017

purkhusid commented Oct 12, 2017

shantanugadgil commented Apr 12, 2018

stefanthorpe commented Apr 27, 2018

rhodrid commented Jun 13, 2018

ghost commented Sep 11, 2018

zoobab commented Oct 12, 2018

dbaumgarten commented Dec 6, 2019

shantanugadgil commented Dec 6, 2019

bbetter173 commented Feb 5, 2020

ghost commented Feb 7, 2020

sirlatrom commented Feb 7, 2020 •

edited

Loading

ghost commented Feb 8, 2020

josephholsten commented Feb 13, 2020

Omarimcblack commented May 4, 2020 •

edited

Loading

josephholsten commented May 4, 2020

hashicorp-cla commented Jun 8, 2020

JnMik commented Aug 12, 2020

josephholsten commented Aug 14, 2020

jeffery commented Aug 19, 2020

tjhiggins commented Sep 29, 2020 •

edited

Loading

josephholsten commented Sep 30, 2020

mildwonkey commented Oct 1, 2020

ghost commented Nov 1, 2020

adding exclude flag to plan and apply to exclude specified resource from map #3366

adding exclude flag to plan and apply to exclude specified resource from map #3366

Conversation

josephholsten commented Sep 30, 2015

phinze commented Dec 15, 2015

josephholsten commented Feb 4, 2016

metcalfc commented Jun 7, 2016

holybit commented Sep 19, 2016

carrete commented Nov 4, 2016

dominik-lekse commented May 3, 2017

josephholsten commented Jun 11, 2017

josephholsten Jun 11, 2017

Choose a reason for hiding this comment

josephholsten Jun 11, 2017

Choose a reason for hiding this comment

purkhusid commented Oct 12, 2017

shantanugadgil commented Apr 12, 2018

stefanthorpe commented Apr 27, 2018

rhodrid commented Jun 13, 2018

ghost commented Sep 11, 2018

zoobab commented Oct 12, 2018

dbaumgarten commented Dec 6, 2019

shantanugadgil commented Dec 6, 2019

bbetter173 commented Feb 5, 2020

ghost commented Feb 7, 2020

sirlatrom commented Feb 7, 2020 • edited Loading

ghost commented Feb 8, 2020

josephholsten commented Feb 13, 2020

Omarimcblack commented May 4, 2020 • edited Loading

josephholsten commented May 4, 2020

hashicorp-cla commented Jun 8, 2020

JnMik commented Aug 12, 2020

josephholsten commented Aug 14, 2020

jeffery commented Aug 19, 2020

tjhiggins commented Sep 29, 2020 • edited Loading

josephholsten commented Sep 30, 2020

mildwonkey commented Oct 1, 2020

ghost commented Nov 1, 2020

sirlatrom commented Feb 7, 2020 •

edited

Loading

Omarimcblack commented May 4, 2020 •

edited

Loading

tjhiggins commented Sep 29, 2020 •

edited

Loading