Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Lb cookie stickiness #3860

Closed
wants to merge 2 commits into from

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 11, 2015

This is based off #2907 and incorporates the feedback from @radeksimko. Decided to open a PR for this because the issue has been inactive since Sept 19th

//cc @radeksimko

chrismarshall and others added 2 commits July 31, 2015 20:03
…ying to set it to 0 when the configuration is omitted, which is rejected by AWS. With this change Terraform will now send null when cookie_expiration_period is set to 0.

I tried leaving cookie_expiration_period as optional, but when updating an existing cookie_expiration_period from a number >0 to omitting it from the configuration Terraform made the change an update which failed as stickiness policies can't be updated.
@catsby
Copy link
Contributor

catsby commented Nov 13, 2015

Ugh, sorry @stack72 looks like I duplicated this PR just this morning in #3908 😦

Going to go with mine since I include some validation and a test, sorry!

@catsby catsby closed this Nov 13, 2015
@stack72
Copy link
Contributor Author

stack72 commented Nov 13, 2015

NPS at all :)

@stack72 stack72 deleted the lb_cookie_stickiness branch November 26, 2015 11:16
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants