Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix issue with LB Cookie Stickiness and empty expiration period #3908

Merged
merged 2 commits into from
Nov 20, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Nov 13, 2015

cookie_expiration_period is optional for the aws_lb_cookie_stickiness_policy resource, however we were sending the default value (0) if nothing was in the configuration, which is invalid.

The change in resource_aws_lb_cookie_stickiness_policy_test confirms the bug/fix

Fixes #3208

@catsby
Copy link
Contributor Author

catsby commented Nov 13, 2015

going to add a validation here... added validation in e94fcdb

@ckelner
Copy link

ckelner commented Nov 13, 2015

Looks good to me @catsby :) thanks for taking care of this!

@stack72
Copy link
Contributor

stack72 commented Nov 13, 2015

This looks good @catsby :)

@stack72
Copy link
Contributor

stack72 commented Nov 13, 2015

actually @catsby, #2907 can also be closed now due to this PR

@phinze
Copy link
Contributor

phinze commented Nov 18, 2015

LGTM

catsby added a commit that referenced this pull request Nov 20, 2015
provider/aws: Fix issue with LB Cookie Stickiness and empty expiration period
@catsby catsby merged commit 9edbf6a into master Nov 20, 2015
@mitchellh mitchellh deleted the b-elb-cookie-fix branch March 22, 2016 19:21
omeid pushed a commit to omeid/terraform that referenced this pull request Mar 30, 2018
Add service config for Lex to ease separation of PRs for Lex resources
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookie_expiration_period for aws_lb_cookie_stickiness_policy is not optional
4 participants