Make use of ComputedWhen in aws_s3_bucket_object #5330

This commit allows "detaching" to be a valid pending state when detaching a volume. Despite being obvious pending state, it also helps in race situations when a volume is implicitly being detached by Nova.

…ching-state provider/openstack: Add detaching as valid pending state

The top level object was used not the tags within

This commit protects against unsafe typecasting when an instance is updating its network configuration.

…twork-update-guard provider/openstack: Safely typecast network during instance update

hashicorpGH-4812 removed reading server.AccessIPv4 and server.AccessIPv6 because, AFAICT, they are not set by Nova. After removal, a user reported that they were no longer able to read IPs from access_ip_v4 and access_ip_v6 on Rackspace. It's possible that Rackspace sets the AccessIPv* attributes, and if that's true, other cloud providers might as well through custom extensions. The priority of how access_ip_v* is set might require some tweaks in the future.

…-version-not-required Lambda S3 object version defaults to '$LATEST' if unspecified

…r-access provider/openstack: Re-Add server.AccessIPv4 and server.AccessIPv6

provider/aws: `aws_elastisearch_domain` tags not being set correctly.

Helpful when iterating on a drift test. Eventually I think this assertion could be fanned out to something much more targeted like: ExpectAttributeDiff(resource, attr, oldval, newval) But this is a step in the right direction.

The `description` field is easy to confuse for a nice field to add an arbitrary comment to - and it's surprising that changes to this field force a new resource, so we add a big note about it to point users at tags. Also marked all the other ForceNew attributes on this resource.

…ptyplan-log acctests: log a line w/ the non-empty plan

…rcenew provider/aws docs: Mark ForceNew fields, note about description

Acctest info in README was a bit stale since the enhanced contributing guide landed.

README: link off to CONTRIBUTING for acctest info

helper/schema: Allow identification of a new resource in update func

Autoscaling Group

provider/aws: Autoscaling Metrics Collection resource

This is to just catch possible breakage in the future. The actual support was done in Gophercloud. Previously, values of 0 were not allowed since there's no such port as 0. However, there are ICMP codes of 0.

provider/aws: Allow recovering from failed CloudWatch Event Target creation

…tems Add MaxItems attribute to Schema

refs hashicorp#5372

deps: update hcl to latest

…mp-zero provider/openstack: Allow ICMP Security Groups with values of zero

Updates to docs per request on mailer

The GCE API for creating VPN tunnels began validating the `peerIp` field and rejecting RFC5735 addresses. The previous test was using one of these addresses and failing as a result. This commit uses 8.8.8.8 for the peerIp.

provider/google: Fix VPN tunnel creation test

Acceptance tests for Pubsub topics and subscriptions failed after incorrectly determining that resources were not deleted in the CheckDestroy phase. Fixes 5437

provider/google: Fix Pubsub acceptance tests

…that are put into a bucket.

…nantnet-403 provider/openstack: Account for a 403 reply from os-tenant-networks

In hashicorp#4700 while fixing a data race I made an incorrect assumption about the return value of StateChangeConf, and ended up changing the behavior in the timeout case to always return: > timeout while waiting for state to become '[success]' When it used to capture the "most recent error" from the function itself. It's much more useful to see that error bubbling up, so here we revert to pulling it out of the function as we did before, and we protect against the data race with a good old fashioned mutex.

…vided and now with ServerSideEncryption we can go back to the higher level PutObject.

Stream information is at the table level and not at the LSI / GSI Reference: http://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_CreateTable.html Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>

closes hashicorp#5448

these changes were added to reflect what was required to run the tutorial on my local machine. Below is my context for the above changes: ```shell [2016-03-04T18:22:44] micperez in terraform_test λ terraform remote config -backend-config="name=puhrez/getting-started" missing 'access_token' configuration or ATLAS_TOKEN environmental variable If the error message above mentions requiring or modifying configuration options, these are set using the `-backend-config` flag. Example: -backend-config="name=foo" to set the `name` configuration [2016-03-04T18:23:27] micperez in terraform_test λ export ATLAS_TOKEN=<REDACTED> [2016-03-04T18:24:12] micperez in terraform_test λ terraform remote config -backend-config="name=puhrez/getting-started" Remote state management enabled Remote state configured and pulled. [2016-03-04T18:24:16] micperez in terraform_test λ terraform push -name="puhrez/getting-started" An error has occurred while archiving the module for uploading: error detecting VCS: no VCS found for path: /Users/micperez/code/terraform_test [2016-03-04T18:24:39] micperez in terraform_test λ git init Initialized empty Git repository in /Users/micperez/code/terraform_test/.git/ [2016-03-04T18:25:09] micperez in terraform_test [git:master] λ terraform push -name="puhrez/getting-started" An error has occurred while archiving the module for uploading: error getting git commit: exit status 128 stdout: stderr: fatal: bad default revision 'HEAD' [2016-03-04T18:25:12] micperez in terraform_test [git:master] λ git status On branch master Initial commit Untracked files: (use "git add <file>..." to include in what will be committed) .terraform/ example.tf terraform.tfstate.backup nothing added to commit but untracked files present (use "git add" to track) [2016-03-04T18:25:17] micperez in terraform_test [git:master] λ git add example.tf [2016-03-04T18:25:24] micperez in terraform_test [git:master] λ git commit -m "init commit" [master (root-commit) 34c4fa5] init commit 1 file changed, 10 insertions(+) create mode 100644 example.tf [2016-03-04T18:25:32] micperez in terraform_test [git:master] λ terraform push -name="puhrez/getting-started" Uploading Terraform configuration... Configuration "puhrez/getting-started" uploaded! (v1) ```

Bring usage docs up to date

Fix DynamoDB stream attribute scope

…hardcount provider/aws: Adding a test for AWS Kinesis Stream Shard Count

…m-shard-count provider/aws: Report the correct number of shards for Kinesis streams

provider/aws: API Gateway resources

provider/aws: Cleanup nitpicks in new API Gateway resources

website: Fix missing sidebar_current

Fix Atlas tutorial steps for currently released version

…ction

Before: "" -> "Error parsing JSON: unexpected end of JSON input" After: "" -> ""

…_template" This was missing in the docs yet was implemented in Terraform. See line 81 in https://github.com/hashicorp/terraform/blob/master/builtin/providers/google/resource_compute_instance_template.go

Added disk_size_gb documentation to resource "google_compute_instance_template"

fix indentation in test

…andling provider/docker fix image test assertions

…olicy provider/aws: Fix error parsing JSON in S3 bucket policy

insert missing word

@catsby

…te, and Environment This adds support for Elastic Beanstalk Applications, Configuration Templates, and Environments. This is a combined work of @catsby, @dharrisio, @Bowbaq, and @jen20

…y-retval helper/resource: restore retval of resource.Retry on timeout

fixes hashicorp#5489

Acceptance tests for GCS that do rapid create/delete/create on GCS buckets using the same name sometimes fail as the bucket namespace is eventually consistent. This change makes tests use a random bucket name for each test (adapted from the existing ACL tests).

Added a cast to "(*schema.Provider)"

…in_days)

docs: Make a separate Elastic Beanstalk section in sidebar

- ASG placement tests - Randomize DynamoDB names in tests - tag the sg created in this test to help identify in the console - randomize policy and role names

provider/aws: Randomize more things in the acceptance tests

When a user specifies `-target`s on a `terraform plan` and stores the resulting diff in a plan file using `-out` - it usually works just fine since the diff is scoped based on the targets. When there are tainted resources in the state, however, graph nodes to destroy them were popping back into the plan when it was being loaded from a file. This was because Targets weren't being stored in the Planfile, so Terraform didn't know to filter them out. (In the non-Planfile scenario, we still had the Targets loaded directly from the flags.) By encoding Targets in with the Planfile we can ensure that the same filters are always applied. Backwards compatibility should be fine here, since we're just adding a field. The gob encoder/decoder will just do the right thing (ignore/skip the field) with planfiles stored w/ versions that don't know about Targets. Fixes hashicorp#5183

Add documentation around the `storage_encrypted` parameter

resource

provider/aws: Add support for `description` to `aws_network_interface` resource

…tion Add storage_encrypted as an optional parameter to aws_rds_cluster

ECR

provider/aws: `repository_url` is computed for `aws_ecr_repository`

…e_preemptible Fix Google instance template creation for preemptible VM

@ephemeralsnow

Fixes an issue where security groups would fail to update after applying an initial security_group, because we were improperly saving the id of the group and not the name (EC2 Classic only). This is a PR combining hashicorp#4983 and hashicorp#5184 . It's majority @ephemeralsnow's work.

…accessible-read provider/aws: aws_db_instance doesn't read publicly_accessible from AWS

All of these RetryErrors were meant to fail right away, but instead caused retry looping because the typecheck in the implementation of `resource.Retry()` only catches the value type, and not the pointer type. Refs hashicorp#5537

Fixes hashicorp#5531.

provider/aws: Retry DB Creation on IAM propigation error

Make aws_route and aws_route_table docs consistent

…inters-are-evil provider/aws: Fix all pointer RetryError returns

provider/aws: Fixes the use of Uppercase chars in ELB Listeners

…in_layout Documentation: Link to vsphere_folder resource missing in vsphere provider layout

…y-groups-updates provider/aws: Support additional changes to security groups of instance without forcing new

Change the `RetryFunc` from a plain `error` return type to a specialized `RetryError` which must decide whether it is retryable or not. Add `RetryableError` / `NonRetryableError` factory functions that callers are meant to use to build up these errors. This makes it eminently clear whether or not a given error is retryable from inside the client code. Goal here is to _not_ change any behavior, simply reflect the existing behavior with the new, clearer, API.

…inters-are-evil builtin: Refactor resource.Retry to clarify return

provider/aws: Add support for KMS

provider/google: Address flaky GCS acceptance tests.

provider/google: Validate VPN tunnel peer_ip

…and etag as well as using aws_kms_key to test aws_s3_bucket's kms_key_id.

docs: fix spelling

helper/resource: Error shouldn't be returned in case of success

provider/aws: Fix EC2 Classic SG Rule issue

provider/cloudstack docs: add vpc.network_domain

…group-protocol-case-sensitivity provider/aws Always transform aws_security_group protocol to lower case

…provider.

This deals with some of the quirks of interacting with the Consul API, with the goal of making the consul_keys resource implementation, and later the consul_keys data source, less noisy to read.

Previously this resource managed the set of keys as a whole rather than the individual keys, and so it was unable to recognize when a particular managed key is removed and delete just that one key from Consul. Here this is addressed by recognizing that each key actually has its own lifecycle, and detecting when individual keys are added and removed without replacing the entire consul_keys instance. Additionally this restores the behavior of updating the "value" attribute on read, but restricts it only to blocks that already had a value so as to avoid the quirkiness seen previously when we updated blocks that were intended to be read-only. Updating the value is important now, because we rely on this to detect and repair discrepancies between values stored in Consul and values given in the configuration. This change produces a change in the handling of the "delete" attribute. Before it was considered only when the entire consul_keys resource was deleted, but now it is considered also when a particular key block is removed from within a resource.

Make consul_keys behavior less surprising

Turns out the BC code allowed users to move from `filename` to `template` to squash the warning without having to switch from template paths to template contents. Here we warn when `template` is specified as a path so we can remove the functionality in the future and remove this source of confusion. refs hashicorp#3732

…t-bug core: Encode Targets in saved Planfile

…plate-path provider/template: warn when template specified as path

provider/google: Mark next_hop_network as read only.

Working on the green - randomize some Autoscaling lifecycle hook test names - use vpc_security_group_ids for this test

…f instance without forcing new"

provider/aws: More Acc test updates

…stance-security-groups-updates Revert "provider/aws: Support additional changes to security groups of instance without forcing new"

provider/aws: Support KMS encryption of S3 objects

We had actually caught mismatched deps versions between the `kms` package and others, so `godep restore` was not working on master. Fixing it requires a `godep update` so I figured we might as well update to the latest release.

deps: Update vendored aws-sdk-go to v1.1.9

Utilizes hashicorp's go-uuid library for proper random seeding setup.

Moving octet-stream to json for remote http backend

refs #1372

Closes hashicorp#1425

provider/openstack: Fix create/delete statuses in load balancing resources for openstack provider.

- Fixes hashicorp#5457

Fix contradictory aws_autoscaling_group doc

core: Add uuid() interpolate function.

…pdates provider/aws: Add support for updating Lambda function

…, failover types

…int-guard provider/aws: Guard against Nil Reference in Redshift Endpoints

provider/aws: Document set_identifer requirement for Route53 weighted and failover types

…odified

aws: Fix CloudFormation update for parameters & capabilities if not modified

…instance-docs Updated google instance docs with custom instance type

see hashicorp#5336

…b-count provider/aws validate number of load_balancers before creating aws_ecs_service

ComputedWhen is a long `TODO`d schema feature that allows any field to be marked as computed when some terget field changes. Right now Terraform has no way of invalidating a field until it sees _that_ field changes, but there are plenty of examples of scenarios where one field changing implies that another field is going to be assigned a new value.

Commits on Mar 12, 2016

deps: Update hashicorp/hil to latest

jen20 committed Mar 12, 2016

Configuration menu

View commit details

Copy full SHA for e1223b4

Browse repository at this point

Copy the full SHA

e1223b4 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make use of ComputedWhen in aws_s3_bucket_object #5330

Make use of ComputedWhen in aws_s3_bucket_object #5330

Commits on Feb 27, 2016

Commits on Feb 28, 2016

Commits on Feb 29, 2016

Commits on Mar 1, 2016

Commits on Mar 2, 2016

Commits on Mar 3, 2016

Commits on Mar 4, 2016

Commits on Mar 5, 2016

Commits on Mar 6, 2016

Commits on Mar 7, 2016

Commits on Mar 8, 2016

Commits on Mar 9, 2016

Commits on Mar 10, 2016

Commits on Mar 11, 2016

Commits on Mar 12, 2016

Commits on Mar 13, 2016