aws: Add elb_account_id data source

[radeksimko]

I'm not sure if data source is the right place for such static lookup, but I can't think of a better place right now.

http://docs.aws.amazon.com/elasticloadbalancing/latest/classic/enable-access-logs.html#attach-bucket-policy

[jen20]

I am generally 👍 on this - exposing as much information as possible via data sources to prevent hard coded values is a good idea IMO!

[jen20]

LGTM pending Travis and running acctests - sorry about the merge conflict there!

[jen20]

› envchain aws.terraform make testacc TEST=./builtin/providers/aws TESTARGS="-run TestAccAWSElbAccountId_basic"
==> Checking that code complies with gofmt requirements...
/Users/James/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 11:43:39 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run TestAccAWSElbAccountId_basic -timeout 120m
=== RUN   TestAccAWSElbAccountId_basic
--- PASS: TestAccAWSElbAccountId_basic (19.17s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    19.187s

[apparentlymart]

I was initially kinda confused by the name of this, thinking to myself "What is an ELB account?"

After reading the linked docs I understand now that this is the account id of the ELB service itself, for each region.

So with that definition in mind, could we instead call this aws_elb_service_account? (The _id suffix is also redundant, since id is an attribute so it causes "stutter".)

So this would look like:

data "aws_elb_service_account" "current_region" {
}
data "aws_iam_policy_document" "elb_access" {
  statement {
    principals {
        type        = "AWS"
        identifiers = "${data.aws_elb_service_account.current_region.id}"
    }
    # etc
  }
}

(Sorry this is a bit of a nit... just concerned that the naming as merged will be misleading and cause people to misunderstand what this is for.)

[apparentlymart]

Maybe clearer to say: "Name of the region whose ELB account id is desired. If not specified, default's to the region from the AWS provider configuration."

[radeksimko]

@apparentlymart Thanks for all the comments, agreed to all points. I'll address that in a separate PR.

[radeksimko]

^ @stack72 FYI - I know there's a decent portion of code you copied from here, so it would be good to make similar changes in #8224

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.