Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Implement naming changes for aws_elb_service_account #8242

Merged
merged 1 commit into from
Aug 16, 2016

Conversation

radeksimko
Copy link
Member

Implementing name changes as discussed in #8221 (comment)

cc @apparentlymart

Acceptance tests

TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSElbServiceAccount -timeout 120m
=== RUN   TestAccAWSElbServiceAccount_basic
--- PASS: TestAccAWSElbServiceAccount_basic (19.94s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    19.961s

@apparentlymart
Copy link
Contributor

LGTM! Thanks for indulging me 😀

@mitchellh
Copy link
Contributor

LGTM, I'm going to merge this right away since we're planning on cutting a 0.7.1 and don't want to otherwise introduce a BC.

@mitchellh mitchellh merged commit 73f685a into hashicorp:master Aug 16, 2016
@radeksimko radeksimko deleted the f-aws-elb-svc-acc-fix branch August 17, 2016 06:09
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants