Update client go to latest #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v1 and v1beta1 AdmissionReview, AdmissionResponse, and AdmissionRequest are the same, so this bumps those to v1. Checks at the start of certWatcher() if AdmissionregistrationV1 exists, and falls back to v1beta1 if it doesn't.
benashz
reviewed
Jul 26, 2021
benashz
reviewed
Jul 26, 2021
and declare payload as a []byte
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
* support v1 and v1beta1 admission api's The v1 and v1beta1 AdmissionReview, AdmissionResponse, and AdmissionRequest are the same, so this bumps those to v1. Checks at the start of certWatcher() if AdmissionregistrationV1 exists, and falls back to v1beta1 if it doesn't. * updating webhook deployment yaml for v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update client-go to v0.21.3. Adds support for switching between v1 and v1beta1 Admission APIs based on availability in the cluster. Since the v1 and v1beta1 AdmissionReview, AdmissionResponse, and AdmissionRequest are the same, this just bumps those to v1. Checks at the start of
certWatcher()if AdmissionregistrationV1 exists, and falls back to v1beta1 if it doesn't.This also is necessary for running on k8s 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes
Tested with our injector acceptance tests on k8s 1.14 and 1.21.
(Split out from #271 for clarity).