set GVK on AdmissionReview responses in webhook #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ravilr
commented
Sep 7, 2021
| @@ -177,7 +177,7 @@ func (a *Agent) newConfig(init bool) ([]byte, error) { | |||
| }, | |||
| Templates: a.newTemplateConfigs(), | |||
| TemplateConfig: &TemplateConfig{ | |||
| ExitOnRetryFailure: a.VaultAgentTemplateConfig.ExitOnRetryFailure, | |||
| ExitOnRetryFailure: a.VaultAgentTemplateConfig.ExitOnRetryFailure, | |||
There was a problem hiding this comment.
make fmt/gofmt change.
tvoran
approved these changes
Sep 11, 2021
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
also fix typo in webhook deploy manifests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying multiple admissionReviewVersions in webhook config with v1 as the first version causes untyped (no GVK) AdmissionReview responses to fail with an error:
failed calling webhook \"vault.hashicorp.com\": expected webhook response of admission.k8s.io/v1, Kind=AdmissionReview, got /, Kind="This error results from the kube-apiserver checking response type for v1.AdmissionReview's but not for v1beta1's. Hence, set the AdmissionReview response object's GVK to the request's type if it exists or defaulting to v1. with this change, either
admissionReviewVersions: ["v1beta1", "v1"]oradmissionReviewVersions: ["v1", "v1beta1"]in webhookconfiguration spec works correctly as expected.deploy/injector-mutating-webhook.yamlmanifest.