-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC Provider Logo (auth0 shown even if not correct) #8949
Comments
is it also possible to enable logo for other providers. may be some customisation settings to specify the logo details |
Thanks for the report! We are not currently able to customize the UI, but while I'm updating this code I would be happy to add logos from other providers. Are there providers other than the ones listed that you'd like to see logos for @techs07 ? |
* glimmerize role-jwt model, update test for use new case * Fix issue #8949 * Update test * Add changelog
PR #20263 closes out this issue, thank you for your patience! |
* glimmerize role-jwt model, update test for use new case * Fix issue #8949 * Update test * Add changelog
* glimmerize role-jwt model, update test for use new case * Fix issue #8949 * Update test * Add changelog
Describe the bug
Vault tries to guess the OIDC provider by matching inaccurate strings in the domain. I.e. if the domain contains "Auth0" it shows a logo for the Auth0 provider. Our OIDC server has the string "auth0" in it's hostname and so this results in an Auth0-logo being shown and therefore is misleading users.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Matching of providers should be based on accurate domain matching. I think the imprecise matching of domains happens here:
vault/ui/app/models/role-jwt.js
Line 12 in 8afe8d0
Environment:
Thanks!
The text was updated successfully, but these errors were encountered: