Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC Provider Logo (auth0 shown even if not correct) #8949

Closed
ttinkr opened this issue May 7, 2020 · 3 comments
Closed

OIDC Provider Logo (auth0 shown even if not correct) #8949

ttinkr opened this issue May 7, 2020 · 3 comments
Labels
bug Used to indicate a potential bug ui

Comments

@ttinkr
Copy link

ttinkr commented May 7, 2020

Describe the bug
Vault tries to guess the OIDC provider by matching inaccurate strings in the domain. I.e. if the domain contains "Auth0" it shows a logo for the Auth0 provider. Our OIDC server has the string "auth0" in it's hostname and so this results in an Auth0-logo being shown and therefore is misleading users.

To Reproduce
Steps to reproduce the behavior:

  1. Enable OIDC
  2. Configure a callback URL which has somewhere in the URL the string "auth0"
  3. Auth0 logo is shown erroneously

Expected behavior
Matching of providers should be based on accurate domain matching. I think the imprecise matching of domains happens here:

auth0: 'Auth0',

Environment:

  • Vault Server Version 1.4.1
  • Vault CLI Version: 1.4.1
  • Server Operating System/Architecture: Kubernetes

Thanks!

@calvn calvn added the ui label May 8, 2020
@austingebauer austingebauer added the bug Used to indicate a potential bug label May 11, 2020
@techs07
Copy link

techs07 commented May 21, 2020

is it also possible to enable logo for other providers. may be some customisation settings to specify the logo details

@hashishaw
Copy link
Contributor

Thanks for the report! We are not currently able to customize the UI, but while I'm updating this code I would be happy to add logos from other providers. Are there providers other than the ones listed that you'd like to see logos for @techs07 ?

hashishaw added a commit that referenced this issue Apr 19, 2023
hashishaw added a commit that referenced this issue Apr 19, 2023
* glimmerize role-jwt model, update test for use new case

* Fix issue #8949

* Update test

* Add changelog
@hashishaw
Copy link
Contributor

PR #20263 closes out this issue, thank you for your patience!

hashishaw added a commit that referenced this issue Apr 20, 2023
* glimmerize role-jwt model, update test for use new case

* Fix issue #8949

* Update test

* Add changelog
hashishaw added a commit that referenced this issue Apr 20, 2023
* glimmerize role-jwt model, update test for use new case

* Fix issue #8949

* Update test

* Add changelog
hashishaw added a commit that referenced this issue Apr 20, 2023
* glimmerize role-jwt model, update test for use new case

* Fix issue #8949

* Update test

* Add changelog
hashishaw added a commit that referenced this issue Apr 20, 2023
* glimmerize role-jwt model, update test for use new case

* Fix issue #8949

* Update test

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

No branches or pull requests

5 participants