UI: OIDC provider logo fix #20263
Merged
UI: OIDC provider logo fix #20263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
approved these changes
Apr 19, 2023
This was referenced Apr 19, 2023
hashishaw
added a commit
that referenced
this pull request
Apr 20, 2023
* glimmerize role-jwt model, update test for use new case * Fix issue #8949 * Update test * Add changelog
hashishaw
added a commit
that referenced
this pull request
Apr 20, 2023
* glimmerize role-jwt model, update test for use new case * Fix issue #8949 * Update test * Add changelog
This was referenced Apr 20, 2023
hashishaw
added a commit
that referenced
this pull request
Apr 20, 2023
hashishaw
added a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #8949 where a logo was showing for the OIDC provider even though it didn't match the top level domain. Added a test for this coverage as well.
This work can be backported, and I will have follow-on work to update the icons to logos that we get from the flight library