Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep symbols by default #20519

Merged
merged 2 commits into from
May 4, 2023
Merged

Keep symbols by default #20519

merged 2 commits into from
May 4, 2023

Conversation

swenson
Copy link
Contributor

@swenson swenson commented May 4, 2023

By reversing the logic and adding a REMOVE_SYMBOLS environment variable that, when set, will remove symbols.

This has been requested to re-enable Dynatrace support, which requires symbols are intact.

Sadly this increases the size (on my mac) from 192,609,682 bytes to 236,696,722 bytes (+23% increase).

I confirmed that this adds symbols back, and that dlv will load the Vault binary.

By reversing the logic and adding a `REMOVE_SYMBOLS` environment
variable that, when set, will remove symbols.

This has been requested to re-enable Dynatrace support, which
requires symbols are intact.

Sadly this increases the size (on my mac) from 192,609,682 bytes
to 236,696,722 bytes (+23% increase).

I confirmed that this adds symbols back, and that `dlv` will load
the Vault binary.
@swenson swenson added this to the 1.13.3 milestone May 4, 2023
@swenson swenson requested review from cipherboy and a team May 4, 2023 18:42
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swenson
Copy link
Contributor Author

swenson commented May 4, 2023

Thanks!

@swenson swenson merged commit fd26fd5 into main May 4, 2023
@swenson swenson deleted the vault-15806/re-enable-symbols branch May 4, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants