Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep symbols by default #20519

Merged
merged 2 commits into from
May 4, 2023
Merged

Keep symbols by default #20519

merged 2 commits into from
May 4, 2023

Commits on May 4, 2023

  1. Keep symbols by default 

    By reversing the logic and adding a `REMOVE_SYMBOLS` environment
variable that, when set, will remove symbols.

This has been requested to re-enable Dynatrace support, which
requires symbols are intact.

Sadly this increases the size (on my mac) from 192,609,682 bytes
to 236,696,722 bytes (+23% increase).

I confirmed that this adds symbols back, and that `dlv` will load
the Vault binary.
    Christopher Swenson committed May 4, 2023
    Configuration menu
    Copy the full SHA
    b43b203 View commit details
    Browse the repository at this point in the history

  2. Add changelog

    Christopher Swenson committed May 4, 2023
    Configuration menu
    Copy the full SHA
    14d6109 View commit details
    Browse the repository at this point in the history