Backport of Bug Fix: Surface Error for when cookie settings prevent localStorage into release/1.14.x #21665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-17601/check-local-storage-supported/explicitly-loved-mantis
branch
from
c57c1ff
to
17839be
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-17601/check-local-storage-supported/explicitly-loved-mantis
branch
from
1efe2c0
to
b128566
Compare
kiannaquach
approved these changes
Jul 7, 2023
Monkeychip
deleted the
backport/ui/VAULT-17601/check-local-storage-supported/explicitly-loved-mantis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21503 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
The new Dismiss License Banner feature uses localStorage. Because the banners are loaded before a user attempts to login, the app was silently failing if a browsers settings did not permit localStorage.
To reproduce:
Before the Dismiss license banners work we caught this error on login and surfaced it in the Login container. While the app still didn't work, it didn't silently fail on first load.
This fix shows the DomException error thrown and appends a small clarifying message afterwards. I didn't want to add a lot of custom logic to the
error.hbstemplate for this one scenario, so it's pretty simple.Note the error that is thrown is readOnly. Here are the MDN docs on the three params returned.
Overview of commits