Bug Fix: Surface Error for when cookie settings prevent localStorage #21503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VioletHynes
added
the
hashicorp-contributed-pr
zofskeez
approved these changes
Jul 7, 2023
Monkeychip
added a commit
that referenced
this pull request
Jul 8, 2023
…21503) * initial fix * changelog * clean up --------- Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Dismiss License Banner feature uses localStorage. Because the banners are loaded before a user attempts to login, the app was silently failing if a browsers settings did not permit localStorage.
To reproduce:
Before the Dismiss license banners work we caught this error on login and surfaced it in the Login container. While the app still didn't work, it didn't silently fail on first load.
This fix shows the DomException error thrown and appends a small clarifying message afterwards. I didn't want to add a lot of custom logic to the
error.hbstemplate for this one scenario, so it's pretty simple.Note the error that is thrown is readOnly. Here are the MDN docs on the three params returned.