Backport 1.13.x: Local storage fix #21701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…21503) * initial fix * changelog * clean up --------- Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
Monkeychip
added
ui
backport
hashicorp-contributed-pr
hashishaw
reviewed
Jul 10, 2023
| @@ -82,6 +83,9 @@ export default Route.extend(ModelBoundaryRoute, ClusterRoute, { | |||
| }, | |||
|
|
|||
| model(params) { | |||
| // if a user's browser settings block localStorage they will be unable to use Vault. The method will throw the error and the rest of the application will not load. | |||
| // localStorage.isLocalStorageSupported(); | |||
There was a problem hiding this comment.
Are we not actually checking if it's supported here?
There was a problem hiding this comment.
Oh, I just started testing on this branch. Thinking that something was wrong with the non-manual backport. I'll close this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry pick of this PR because failing test on automated one I couldn't problem solve.