This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
feat: aws-ecr-pull builder
#3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
evanphx
suggested changes
May 31, 2022
builtin/aws/ecr/pull/builder.go
Outdated
Comment on lines
161
to
166
| // TODO(kevinwang): Do we need to get architecture? | ||
| // If we do, we can pull the image and inspect it via `cli.ImageInspectWithRaw`, | ||
| // - prior art: /builtin/docker/builder.go -> Build | ||
| // There is also an open issue for the ECR team to build a architecture feature into | ||
| // the UI, which probably comes with a CLI/API change. | ||
| // - see https://github.com/aws/containers-roadmap/issues/1591 |
There was a problem hiding this comment.
Since ECR doesn't expose the architecture in an obvious way here yet, I'd probably make an option on the plugin called force_architecture that will set the architecture on output. This will make it at least work with the other bits we've been adding architecture to.
There was a problem hiding this comment.
paladin-devops
added
the
ecosystem
paladin-devops
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
I tested this out with a local & remote runner, looks great! I've also added an example usage of this plugin to the examples repo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3390
Checklist
Usage
app "deno-http" { build { + use "aws-ecr-pull" { + region = var.region + repository = "deno-http" + tag = var.tag + } } deploy { use "aws-lambda" { region = var.region memory = 512 } } release { use "lambda-function-url" { } } }