Export CGid from System.Process.Internals (especially on Windows)

[RyanGlScott]

I found myself wanting to derive some instances for CreateProcess in one of my applications recently, only to discover that it wouldn't work on Windows. Why? Because CreateProcess uses UserID and GroupID fields, the definitions of which are platform-dependent:

#ifdef WINDOWS
-- Define some missing types for Windows compatibility. Note that these values
-- will never actually be used, as the setuid/setgid system calls are not
-- applicable on Windows. No value of this type will ever exist.
newtype CGid = CGid Word32
  deriving (Show, Eq)
type GroupID = CGid
type UserID = CGid
#else
type PHANDLE = CPid
#endif

This Windows-only newtype CGid is only available in the internal System.Process.Common module, and as a result, I can't make any instances for it (and thus can't derive any instances for CreateProcess).

Would you consider reexporting CGid from System.Process.Internals? That way I could accomplish my original goal, and process wouldn't have to make any API promises about the design of CGid.

[snoyberg]

I don't see too serious a downside here. Want to send a PR that you can confirm fixes the problem for you?

…

On Thu, Mar 9, 2017 at 12:41 AM, Ryan Scott ***@***.***> wrote: I found myself wanting to derive some instances for CreateProcess in one of my applications recently, only to discover that it wouldn't work on Windows. Why? Because CreateProcess uses UserID and GroupID fields, the definitions of which are platform-dependent: #ifdef WINDOWS-- Define some missing types for Windows compatibility. Note that these values-- will never actually be used, as the setuid/setgid system calls are not-- applicable on Windows. No value of this type will ever exist.newtype CGid = CGid Word32 deriving (Show, Eq)type GroupID = CGidtype UserID = CGid #elsetype PHANDLE = CPid #endif This Windows-only newtype CGid is only available in the internal System.Process.Common module, and as a result, I can't make any instances for it (and thus can't derive any instances for CreateProcess). Would you consider reexporting CGid from System.Process.Internals? That way I could accomplish my original goal, and process wouldn't have to make any API promises about the design of CGid. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#90>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBB6Pg9GU7U0x1MU14HdAVi3mLfE-dks5rjy6kgaJpZM4MXZ_Y> .