Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export CGid and friends from System.Process.Internals #91

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Re-export CGid and friends from System.Process.Internals #91

merged 1 commit into from
Mar 30, 2017

Conversation

RyanGlScott
Copy link
Member

This re-exports CGid (which was previously unusable on Windows due to its unavailability) from System.Process.Internals. It also re-exports the synonyms GroupID and UserID so that the Haddocks will have a place to point to on Windows.

Fixes #90.

@RyanGlScott
Copy link
Member Author

I'm not sure what went wrong with the AppVeyor build, but I don't think it was caused by these changes.

@snoyberg
Copy link
Collaborator

There was a recent change in AppVeyor that broke a bunch of scripts, see http://help.appveyor.com/discussions/problems/6312-curl-command-not-found. Can you rebase this PR against master? Also, can you include a comment in the changelog about the change?

@RyanGlScott
Copy link
Member Author

@snoyberg, I've rebased and updated the changelog. The AppVeyor build is still failing for some reason, though.

@snoyberg
Copy link
Collaborator

I'm not sure what that error means either, let me play with it a bit. I'd like to hold off on merging this until AppVeyor signs off since it's obviously fairly Windows-specific.

@snoyberg
Copy link
Collaborator

Alright, after a ridiculous amount of pain and suffering I think I've got it fixed. Can you try rebasing against master again?

@RyanGlScott
Copy link
Member Author

The Windows build is finally green! Hooray!

@snoyberg snoyberg merged commit 10f31a5 into haskell:master Mar 30, 2017
@snoyberg
Copy link
Collaborator

Woohoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants