Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated hauler testdata #226

Merged
merged 1 commit into from
Apr 12, 2024
Merged

updated hauler testdata #226

merged 1 commit into from
Apr 12, 2024

Conversation

zackbradys
Copy link
Member

@zackbradys zackbradys commented Apr 6, 2024 •
edited
Loading

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

  • N/A

Types of Changes:

  • Bugfix/Feature

Proposed Changes:

  • Updated testdata with a small manifest and haul (uses the latest formats in hauler)
  • Updated chart_test.go to use updated helm charts (local and remote)

Verification/Testing of Changes:

  • Run hauler commands with the manifest or haul in the testdata
  • Run go test with the chart_test.go

Additional Context:

@zackbradys zackbradys added bug Something isn't working enhancement New feature or request labels Apr 6, 2024
@zackbradys zackbradys self-assigned this Apr 6, 2024
@zackbradys zackbradys added the size/S Denotes an issue/PR requiring a relatively small amount of work label Apr 6, 2024
@zackbradys zackbradys requested review from dweomer and amartin120 April 7, 2024 04:29
@zackbradys zackbradys mentioned this pull request Apr 7, 2024
Merged
3 tasks
amartin120
amartin120 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@amartin120 amartin120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@zackbradys zackbradys merged commit 1a317b0 into hauler-dev:main Apr 12, 2024
1 check passed
@zackbradys zackbradys deleted the testdata branch April 12, 2024 01:57
@zackbradys zackbradys mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amartin120 amartin120 amartin120 approved these changes

@dweomer dweomer Awaiting requested review from dweomer

Assignees

@zackbradys zackbradys

Labels
bug Something isn't working enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zackbradys @amartin120