Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helmifying hauler #227

Merged
merged 3 commits into from
Apr 12, 2024
Merged

helmifying hauler #227

merged 3 commits into from
Apr 12, 2024

Conversation

zackbradys
Copy link
Member

@zackbradys zackbradys commented Apr 7, 2024 •
edited
Loading

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

  • N/A

Types of Changes:

  • Feature

Proposed Changes:

  • Added a helm chart for deploying hauler on kubernetes
  • Able to deploy the registry or fileserver with predefined hauls or manifests

Verification/Testing of Changes:

  • Clone the hauler repository and helm install the chart
  • Able to enable/disable various parts of the chart and it will function correctly

Additional Context:

  • Extensive testing and validation of the chart and other possible implementation of the chart
  • Expecting hauler to improve over time and thus will improve this chart and it's features/functionality
  • Depends on merging updated hauler testdata #226

@zackbradys zackbradys added enhancement New feature or request size/L Denotes an issue/PR requiring a relatively large amount of work labels Apr 7, 2024
@zackbradys zackbradys self-assigned this Apr 7, 2024
@zackbradys zackbradys requested review from dweomer and amartin120 April 7, 2024 04:29
@zackbradys zackbradys mentioned this pull request Apr 7, 2024
Merged
3 tasks
amartin120
amartin120 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@amartin120 amartin120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This will definitely take an additional PR to update if/when we move this to a new GH org.

@zackbradys zackbradys merged commit 44baab3 into hauler-dev:main Apr 12, 2024
1 check passed
@zackbradys zackbradys deleted the helmifying branch April 12, 2024 02:02
@zackbradys zackbradys mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amartin120 amartin120 amartin120 approved these changes

@dweomer dweomer Awaiting requested review from dweomer

Assignees

@zackbradys zackbradys

Labels
enhancement New feature or request size/L Denotes an issue/PR requiring a relatively large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zackbradys @amartin120