feat!(ios): update Firebase Messaging to ~> 8.1.1 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows building with xcode 12 This allows building with xcode 12
…eshedNotification
erisu
changed the title
|
Great thanks @erisu . Any Idea when this will be merged into master? |
|
The current master is incompatible with @capacitor-community/fcm. @erisu Please merge this PR before the next major version, thank you! |
9 tasks
kntrs
pushed a commit
to dejiren/cordova-plugin-push
that referenced
this pull request
Apr 3, 2023
* feat(ios): update IOS_FIREBASE_MESSAGING_VERSION to > 8 * chore(ios): removed unused methods & commented out code * fix(ios): use new notification name FIRMessagingRegistrationTokenRefreshedNotification Co-authored-by: Adri Van Houdt <adri.van.houdt@gmail.com>
|
Is this fix ever going to be released as stable to npm? Developers are wasting lots of time figuring out bugs from 3.0.1 introduced by Firebase BOM and newer GradlePluginKotlinVersion versions that have already been fixed in the 4.0.0 master version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #100 for description.
This PR cherry-picks the changes from #100 and applies the ticket comment suggestions. Also updates to use the new notification name/key
FIRMessagingRegistrationTokenRefreshedNotificationCloses #100
Closes #84