Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): increase firebase framework to 7.11.0 #97

Closed
wants to merge 1 commit into from

Conversation

ollm
Copy link

@ollm ollm commented May 5, 2021

Description

Plugin cannot be installed in parallel with https://github.com/admob-plus/admob-plus or https://github.com/chemerisuk/cordova-plugin-firebase-analytics because of incompatible Firebase SDK versions.

Related Issue

#84

Motivation and Context

I use the plugin together with admob-plus and cordova-plugin-firebase-analytics

How Has This Been Tested?

cordova platform rm ios
cordova plugin add cordova-plugin-push
cordova platform add ios@6.2.0
cd platforms/ios
pod install

I have tested it on an iPhone 6s with iOS 14.5 and notifications are received without problems, except when the application is in the foreground, the event push.on('notification', function(){}); does not fire, I don't know if this bug is due to the changes or it was already present in the plugin.

I'm not very familiar with Objective-C and the Firebase SDK, so I'm not sure if the removed identifiers would have to be replaced with something.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu
Copy link

erisu commented Apr 11, 2022

Closing out this PR as PR #152 bumped the firebase framework to 8.1.1 and was merged into the main branch.

Thank you for your PR submission.

@erisu erisu closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants