Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hanging on "async with BleakClient..." on OSX #213

Closed
wants to merge 1 commit into from

Conversation

ShaharHD
Copy link

@ShaharHD ShaharHD commented Jun 7, 2020

Fix for issue #116

@hbldh hbldh self-assigned this Jun 23, 2020
@hbldh hbldh added Backend: Core Bluetooth Issues and PRs relating to the Core Bluetooth backend duplicate This issue or pull request already exists labels Jun 23, 2020
@hbldh
Copy link
Owner

hbldh commented Jun 23, 2020

I just saw the changes in #209, which solves this issue in another way, which I think will yield an even better result in the end. Thank you for the PR though! I will close this and if #209 does not solve the same issue, we will ahve to revisit this later on.

@hbldh hbldh closed this Jun 23, 2020
@ShaharHD
Copy link
Author

ShaharHD commented Jun 23, 2020

@hbldh Why not incorporate the fix right now (It is a limited fix, specific to OS X)?

And once #209 PR (which is huge) is completed, it will overwrite this fix?

Right now - every time I install Bleak, I need to have a script to manually patch it - as without this fix, bleak is unusable on OS X.

@hbldh
Copy link
Owner

hbldh commented Jun 24, 2020

Because I have no desire to make two releases so close to each other. There will be one next week, so I will wait until then.

It is not unusable on macOS. I used it just fine a minute ago.

@ShaharHD
Copy link
Author

ShaharHD commented Jun 24, 2020

Look at comments of the other users on #116 which confirms my fix works.

@ShaharHD
Copy link
Author

It is not unusable on macOS. I used it just fine a minute ago.

Be aware you were not able to reproduce the issue last year as well.

@hbldh hbldh added this to the Version 0.7.X milestone Jun 30, 2020
@hbldh
Copy link
Owner

hbldh commented Jun 30, 2020

I have merged #227 into develop and will make a version 0.7.0 release later today with those changes as well as a lot of others. If the "fire twice" problem is still left after release of version 0.7.0, I will include these changes in a version 0.7.X release tomorrow.

@hbldh hbldh reopened this Jul 2, 2020
@hbldh hbldh modified the milestones: Version 0.7.X, Version 0.8.0 Jul 9, 2020
hbldh added a commit that referenced this pull request Jul 20, 2020
@hbldh hbldh mentioned this pull request Sep 2, 2020
@hbldh hbldh closed this in #279 Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend: Core Bluetooth Issues and PRs relating to the Core Bluetooth backend duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants