CoreBluetooth fixes #227
Merged
CoreBluetooth fixes #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _central_manager_delegate_ready task doesn't appear to do anything useful (not used by anything) and it may never finish which can cause an error when an application exits. Task was destroyed but it is pending! task: <Task pending name='Task-2' coro=<Application._central_manager_delegate_ready() running at bleak/backends/corebluetooth/__init__.py:46>>
This replaces hard-coded numbers with constants from objc bindings
core bluetooth has to wait until centralManagerDidUpdateState_ is called and the state is CBManagerStatePoweredOn before any other bluetooth functions can be used. Since __init__ can't be async, this means we have to move the check to the other async entry points of discovery and scanner.
Apparently some things were removed from the CentralManagerDelegate that kept track of scanned peripherals. This replaces it with a new implementation in BleakScannerCoreBluetooth instead.
This replaces the NSRunLoop integration in the corebluetooth backend with a dispatch queue. This causes callbacks to be dispatched on a background thread instead of on the main dispatch queue on the main thread. `call_soon_threadsafe()` is used to synchronize the events with the event loop where the central manager was created. The NSRunLoop caused problems because it had to manually be called from the main thread. This left an asyncio task that had to be manually stopped at the end of a program to prevent errors about the still running task (issue: hbldh#111). The NSRunLoop implementation was also not very efficient since it was waking up the event loop every millisecond to check for events.
This removes the global Application() class in the corebluetooth backend. Instead, a new central manager is created for each scanner object. Since an instance of the `Application()` was created on module import, it could interfere with other code like introspection tools that don't actually want to run `bleak`. This also fixes running `bleak` in threads (hbldh#206).
The pyobjc package requires in all pyobjc-* packages, most of which we don't use. This fixes the requirements so that we only install the packages we are using.
|
This looks very good! Thank you, this will definitely improve the starting point of my bleak Tuesday next week. Does the use of the dispatch queue alleviate any of the issues in #206? Or is the matter of a shared cbapp / central manager still impeding with multi-thread use of bleak in iOS? |
|
Ah, saw the note in one of the commits. Strike the question. Thank you! |
hbldh
added
Backend: Core Bluetooth
|
This looks terrific. Will merge and use it as basis for more work. Thank you very much! |
This was referenced Jun 30, 2020
hbldh
added a commit
that referenced
this pull request
Jun 30, 2020
This was referenced Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some of the fixes I have been working on. If fixes several of the outstanding CoreBluetooth issues. I didn't rebase on #209 because that PR seems a bit unfinished.