Fix get_services() fails because no GattSession
#973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the following error occurred when connecting, set the MTU to the default 20 to avoid it. `AttributeError: 'NoneType' object has no attribute 'max_pdu_size'`
|
If |
|
@dlech Thank you for your reply! Test code is here: https://github.com/nv-h/nRF52_sensors/blob/master/test/search_and_connect.py |
|
Thanks for the logs.
This is what I was expecting to see. It looks as if the device is disconnecting even though we tell Windows to stay connected. Can you also get a Wireshark log of the Bluetooth packets when the problem happens (see troubleshooting page in bleak docs for howto)? I would like to see if Windows is disconnecting or if the device itself is disconnecting or if it is not disconnecting at all. |
|
I see. So, does my workaround match? I've attached the packet capture results when I try and reproduce it 3 times. |
Does this mean the first two attempts did not have a problem and the 3rd attempt did have the problem? |
Yes! |
|
This shows that the device disconnected itself about 1/4 of a second after connecting (before the MTU exchange was complete). So, I don't think the workaround is the correct solution here. Instead, the connect method should fail because the device disconnected before the services could be retrieved. Then the connection can be retried later. |
|
Thank you for the explanation. So, I think that try to write the retry process in the application code by catch AttributeError. |
|
I would accept a PR that adds if not self.is_connected:
raise BleakError("Not connected")to That would be more informative than an AttributeError. |
|
Thank you. I added it like this commit. |
dlech
requested changes
Sep 2, 2022
|
Thank you for review. I changed place and added changelog. |
dlech
approved these changes
Sep 3, 2022
Based on BlueZ's implementation
|
Added a connection check referring to BlueZ's implementation. I didn't see the implementation, so I'm sorry for bothering you twice. |
dlech
requested changes
Sep 5, 2022
|
Merged, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the following error occurred when connecting, set the MTU to the default 20 to avoid it.
AttributeError: 'NoneType' object has no attribute 'max_pdu_size'Tested by Python 3.9 on Windows 11.