Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_services() fails because no GattSession #973

Merged
merged 5 commits into from
Sep 5, 2022
Merged

Fix get_services() fails because no GattSession #973

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ebaa0a3
Fix `get_services()` fails because no GattSession
nv-h Sep 2, 2022
f19970d
Raise an error if already disconnected
nv-h Sep 2, 2022
d2e7a8d
Change place of added code
nv-h Sep 3, 2022
60d41c3
Check is_connected in other functions as it may be disconnected
nv-h Sep 3, 2022
7d9a0df
Fix changelog to match implementation
nv-h Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bleak/backends/winrt/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,9 @@ async def get_services(self, **kwargs) -> BleakGATTServiceCollection:
"Could not get GATT services",
)

if not self.is_connected:
nv-h marked this conversation as resolved.
Show resolved Hide resolved
raise BleakError("Not connected")

for service in services:
# Windows returns an ACCESS_DENIED error when trying to enumerate
# characteristics of services used by the OS, like the HID service
Expand Down