Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable/disable improve_placement for P&R targets #244

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

mtdudek
Copy link
Collaborator

@mtdudek mtdudek commented Dec 14, 2023

This adds new enable_improve_placement attr to place_and_route rule.
improve_placement pass breaks some of the designs,
so having option to disable is beneficial for some users.
Default behavior remains unchanged.

First part of the #243 PR.

Some designs fail on during resize script. This script runs
`detailed_placement` followed by `improve_placement` command.
I've noticed that `improve_placement` causes some cell to
either be place to close together triggering overlap warning
or they truly overlapped. I checked overlapping reports using
OpenROAD GUI interface.

Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
Copy link
Member

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mithro mithro merged commit 828ab34 into hdl:main Dec 14, 2023
4 checks passed
@mtdudek mtdudek deleted the 52551-improved_placement_flag branch December 15, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants