-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synthesis and P&R: Move closer to OpenROAD-flow-scripts #243
Conversation
Synthesis: This commit adds a custom abc.script from OpenROAD-flow-scripts. This commit also modifies the synthesis script. It adds 2 new steps: extract adders - it tries to map addition chains to PDK specific full adder and half adder improving overall performance. Runs only when `adder_mapping` attr is provided. tie logic cells - it runs `hilomap` pass. P&R: This commit changes output_db file extention to .odb. OpenROAD file explorer only allows for .odb to be opened from GUI. Allow user to disable `improve_placement` pass during resize step. It can cause cell overlapping both by not maintaining sufficient cell to cell spacing as well as true cell overlapping. Some other minor changes to the P&R scripts. Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is going to be a bit complicated to land as it affects the results on Google internal benchmarks. It would be good if we could land this in multiple parts.
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about this, but I think we need this pull request split into the following;
enable_improve_placement
functionality (should be quick to merge).db
into.odb
(should be quick to merge)estimate_parasitics
addition (should be quick to merge)set_propagated_clock
&detailed_route
addition (may cause issues)remove_buffers
change (may cause issues)- Tie cell & hi/low change (may cause issues)
- Adder mapping (may cause issues)
- ABC script. (may cause issues)
Would you be able to do that?
@@ -210,9 +210,9 @@ def openroad_command(ctx, commands, input_db = None, step_name = None, inputs = | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you send this changes in this file as a separate pull request. That can be quickly merged then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I'll split it into smaller changes
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
I'm going to close this pull request as we are landing it in parts. |
Synthesis:
This commit adds a custom abc.script from OpenROAD-flow-scripts. This commit also modifies the synthesis script. It adds 2 new steps: extract adders - it tries to map addition chains to PDK specific full adder and half adder improving overall performance. Runs only when
adder_mapping
attr is provided.tie logic cells - it runs
hilomap
pass.P&R:
This commit changes output_db file extention to .odb. OpenROAD file explorer only allows for .odb to be opened from GUI.
Allow user to disable
improve_placement
pass during resize step. It can cause cell overlapping both by not maintaining sufficient cell to cell spacing as well as true cell overlapping.Some other minor changes to the P&R scripts.
Edit:
Related to #239