P&R: Run estimate_parasitics before clock repair #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds parasitic estimation after `clock_tree_synthesis` and before `repair_clock_nets`. This is done in the OpenROAD-flow-scripts. Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
mithro
reviewed
Dec 18, 2023
| @@ -47,6 +47,7 @@ def clock_tree_synthesis(ctx, open_road_info): | |||
| sink_clustering_max_diameter = "-sink_clustering_max_diameter {}".format(ctx.attr.sink_clustering_max_diameter) if ctx.attr.sink_clustering_max_diameter else "", | |||
| ), | |||
| "set_propagated_clock [all_clocks]", | |||
| "estimate_parasitics -placement", | |||
| "repair_clock_nets", | |||
| "estimate_parasitics -placement", | |||
There was a problem hiding this comment.
Is estimate_parasitics -placement still needed after repair_clock_nets now?
There was a problem hiding this comment.
I think yes, as repair_clock_nets may add extra buffer cells.
This was referenced Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds parasitic estimation after
clock_tree_synthesisandbefore
repair_clock_nets. This pass is also run in the ORFS.Third part of the #243