Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates from JavaScript version #2

Closed
happy5214 opened this issue Aug 16, 2019 · 1 comment · Fixed by #66
Closed

Updates from JavaScript version #2

happy5214 opened this issue Aug 16, 2019 · 1 comment · Fixed by #66
Assignees
@happy5214

Comments

@happy5214
Copy link
Member

happy5214 commented Aug 16, 2019 •
edited
Loading

I have made the following changes in my JavaScript version of the HED validator (https://github.com/VisLab/HEDBidsValid/tree/semantic):

  • TagValidator
    • Deleted get_next_set_of_parentheses_in_hed_string(), _get_index_at_end_of_parentheses(), and _is_valid_tag_with_parentheses(), along with the parentheses check from find_comma_issues_in_hed_string(), as parentheses are no longer permitted in HED tags.
  • HedDictionary
    • Recursively added descendants of extensionAllowed tags to that dictionary, as in this JS code.
@happy5214
Copy link
Member Author

Also, TagValidator.is_numeric_tag() doesn't appear to be used outside the testcases.

@happy5214 happy5214 mentioned this issue Sep 16, 2019
Closed
happy5214 pushed a commit that referenced this issue May 6, 2020
@owinterbg
Merge pull request #2 from happy5214/owinterbg/forked_master
8d95453 
Fix schema URL
@happy5214 happy5214 self-assigned this Jun 26, 2020
happy5214 added a commit to happy5214/hed-python that referenced this issue Jul 4, 2020
@happy5214
Remove some old code and tests and update to reflect JS version
2feb49a 
Fixes hed-standard#2
Fixes hed-standard#7
@happy5214 happy5214 mentioned this issue Jul 4, 2020
Merged
@VisLab VisLab closed this as completed in #66 Jul 5, 2020
@IanCa IanCa mentioned this issue Apr 17, 2021
Closed
VisLab pushed a commit that referenced this issue Jan 12, 2023
@IanCa
Merge pull request #2 from IanCa/develop
92ba027 
Add alternate api.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@happy5214 happy5214

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve old outstanding issues happy5214/hed-python
1 participant
@happy5214