Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve old outstanding issues #66

Merged
merged 6 commits into from
Jul 5, 2020

Conversation

happy5214
Copy link
Member

@happy5214 happy5214 commented Jul 4, 2020

This pull request resolves an assortment of older issues related to code improvements in the JavaScript version of the validator.

Fixes #2
Fixes #6
Fixes #7
Fixes #9

@happy5214 happy5214 self-assigned this Jul 4, 2020
@VisLab
Copy link
Member

VisLab commented Jul 4, 2020

I cleaned up the data files in test. The HED.xml in test was also replaced because there was an error in the .xml. I updated the versions on the web as well.

@happy5214
Copy link
Member Author

This is part 1 of fixing the outstanding issues. This has the relatively simple fixes for early issues. Other older issues will be dealt with separately.

@happy5214 happy5214 marked this pull request as ready for review July 5, 2020 11:56
@happy5214 happy5214 requested a review from VisLab July 5, 2020 11:56
@VisLab VisLab merged commit 07bf9dc into hed-standard:master Jul 5, 2020
@happy5214 happy5214 deleted the outstanding-issues branch July 6, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants