Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflicts between prompt/picker bindings #1792

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

crodjer
Copy link
Contributor

@crodjer crodjer commented Mar 11, 2022

Currently, the picker's re-using a few bindings which are also present
in the prompt. This causes some editing behaviours to not function on
the picker.

Ctrl + k and Ctrl + j
This should kill till the end of the line on prompt, but is overridden
by the picker for scrolling. Since there are redundancies (Ctrl + p,
Ctrl + n), we can remove it from picker.

Ctrl + f and Ctrl + b
This are used by the prompt for back/forward movement. We could modify
it to be Ctrl + d and Ctrl + u, to match the vim behaviour.

Currently, the picker's re-using a few bindings which are also present
in the prompt. This causes some editing behaviours to not function on
the picker.

**Ctrl + k** and **Ctrl + j**
This should kill till the end of the line on prompt, but is overridden
by the picker for scrolling. Since there are redundancies (`Ctrl + p`,
`Ctrl + n`), we can remove it from picker.

**Ctrl + f** and **Ctrl + b**
This are used by the prompt for back/forward movement. We could modify
it to be Ctrl + d and Ctrl + u, to match the `vim` behaviour.
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't know if I use ctrl-k/-j or -p/-n on the picker but I guess we'll see, I might need to retrain my muscle memory :D

@archseer archseer merged commit 5d61631 into helix-editor:master Mar 31, 2022
@EpocSquadron
Copy link
Contributor

EpocSquadron commented Mar 31, 2022

The ctrl-f and ctrl-b bindings were for consistency with full or half height scrolling as in #1614. I do think ctrl-d and ctrl-u should be present, but they should advance by half height. The pr that implemented the others #1612 mentioned it would be a little more difficult to do though.

Cc: @archseer

@heliostatic
Copy link
Contributor

Ah, I missed this PR -- I opened the original issue to add <C-j> and <C-k> (#615), and do prefer using those. But really, the best solution seems to be allowing remapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants