[stable/external-dns] Add the ability for external-dns to manage records with Istio Virtual…

[thomasv314]

Add the ability for external-dns to manage records with Istio Virtual Service resources

Required when either of these PR's is merged:

kubernetes-sigs/external-dns#1358
kubernetes-sigs/external-dns#1607

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

This PR gives external-dns the ability to inspect VirtualService resources and delegate domain records to them.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/mychartname])

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thomasv314
To complete the pull request process, please assign juan131
You can assign the PR to them by writing /assign @juan131 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• stable/external-dns/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @thomasv314. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[thomasv314]

This should be good to go now that istio virtualservices are supported in external-dns

kubernetes-sigs/external-dns#1607

/assign @juan131

[Karthik-13]

@thomasv314 @juan131 will this feature be merged soon? We are running istio and knative workloads in our cluster with external-dns configured and this would solve a lot of our problems

[juan131]

Given the stable deprecation timeline, this Bitnami maintained Helm chart is now located at bitnami/charts. Please visit the bitnami/charts GitHub repository to create Issues or PRs.

In this issue we tried to explain more carefully the reasons and motivations behind this transition, please don't hesitate to add a comment in this issue if you have any question related to the migration itself.

[thomasv314]

@juan131 I appreciate you taking the time to clarify, thanks!

@Karthik-13 this is merged into bitnami/charts: bitnami/charts#3216

[Karthik-13]

@thomasv314 @juan131 The helm chart has the support for virtualservice added. But the image mentioned in values.yaml doesn't have the feature and is causing the pod to fail.
I've created an issue under bitnami chart repos here: bitnami/charts#3275

Could you please specify which version of bitnami/external-dns image to use?

[thomasv314]

@Karthik-13 Yep, IMO that's not this charts responsibility. I built off master and pushed to our private registry, the functionality should be available in the next tagged release of external-dns.