add new source for istio virtual services #1607

tariq1890 · 2020-05-28T16:59:33Z

Raising this PR since we would really love to test this feature out in our Istio setup. I have seen that there is a lot of request for this PR to be merged.

This is a dup of #1358. Thanks to @devkid and @elsesiy for their efforts in creating this

Closes #1340
Closes #1358

tariq1890 · 2020-05-29T02:19:55Z

Not sure if the failures are related to this PR.

@sheerun I believe the ticker is being triggered twice and because of that, we are sending to a closed channel which causes the panic in source_test.go

elsesiy · 2020-05-29T07:39:53Z

@tariq1890 This is a dup of #1358. I didn't open another PR myself because @devkid did most of the work already..

sheerun · 2020-05-29T10:07:19Z

@tariq1890 Could you try to fix this test?

tariq1890 · 2020-05-29T16:44:10Z

@elsesiy If you see that PR thread, I had followed up and I hadn't heard back in 10 days.

He will be added as a co-author of this PR of course

elsesiy · 2020-05-29T16:59:09Z

@tariq1890 Sure I understand. Why don’t you preserve the commits from the original PR?

tariq1890 · 2020-05-29T17:43:24Z

I usually squash my commit history and like to keep it clean that way. Plus it was easier making the changes manually instead of git rebasing as a lot of changes have been made since that PR was created

elsesiy · 2020-05-29T17:54:22Z

That's fine but in my opinion you should add everybody who contributed code to this as co-author then :)

tariq1890 · 2020-06-07T06:49:05Z

@elsesiy Done!

tariq1890 · 2020-06-07T07:00:20Z

@thomasv314 Requesting you to test this PR on your clusters. It would be good to confirm if istio client-go works as expected :)

thomasv314 · 2020-06-08T14:59:45Z

@tariq1890 if i have bandwidth today i will give it a go on our development cluster

tariq1890 · 2020-06-09T17:38:43Z

@njuettner @Raffo Requesting your review on this.

tariq1890 · 2020-06-10T23:49:02Z

@thomasv314 Were you able to test this?

Raffo

I added a few comments, I'm definitely not a istio expert, but the changes do look good.

Is there anything that we can do to validate this, for example by testing it in prod @thomasv314 ?

source/source_test.go

Raffo · 2020-06-14T09:07:17Z

source/virtualservice.go

+		},
+	)
+
+	// TODO informer is not explicitly stopped since controller is not passing in its channel.


What can we do to fix that?

This is another copy pasta from the existing gateway source. Unfortunately, I haven't looked into this too much. I can tackle this is another PR if that's okay with you

Gotcha, works.

source/virtualservice.go

Raffo · 2020-06-24T07:45:19Z

@tariq1890 are you able to address the comments?

tariq1890 · 2020-06-24T15:59:38Z

@Raffo Thanks for the follow-up. I have addressed your comments.

tariq1890 · 2020-06-27T00:16:47Z

ping ping @njuettner @Raffo

I have tested this in my development cluster and can confirm that it works

tariq1890 · 2020-06-27T00:25:38Z

@steerben Have you tested this branch?

Raffo · 2020-06-28T07:38:21Z

If we can get an additional +1 from @steerben or anyone else I'm gonna approve for merge.

steerben · 2020-06-29T12:33:47Z

I will give it a run again this evening and will respond! @tariq1890 @Raffo

steerben · 2020-06-29T20:06:14Z

Hey!

I got some issues:

Build went through but tests failed in the docker build:
ok sigs.k8s.io/external-dns/registry 0.060s --- FAIL: TestIngress (10.75s) --- FAIL: TestIngress/Endpoints (10.71s) --- FAIL: TestIngress/Endpoints/template_for_ingress_if_host_is_missing (10.02s) ingress_test.go:1038: Error Trace: ingress_test.go:1038 Error: Received unexpected error: timed out waiting for the condition Test: TestIngress/Endpoints/template_for_ingress_if_host_is_missing FAIL FAIL sigs.k8s.io/external-dns/source 50.725s FAIL make: *** [Makefile:41: test] Error 1

Furthermore I only used istio-virtualservice as source which is not allowed in the current implementation. I got an error from the initial flag parsing, I think this has to be adjusted since it has not been altered in your PR yet your adjusted istio.md doc file states that only one of gateway or virtualservice can be chosen.

Fix has to be made in types.go (pkg/api/externaldns) line 304

I fixed that on my end and it set the DNS entries corrrectly.

Co-authored-by: Alfred Krohmer <alfred.krohmer@logmein.com> Co-authored-by: Jonas-Taha El Sesiy <github@elsesiy.com>

tariq1890 · 2020-06-29T20:34:53Z

@steerben Thank you so much for trying this out! I have fixed the flag issues, but I was not able to replicate those test failures. They seem to be running fine in and out of the docker context.

tariq1890 · 2020-06-29T21:42:39Z

@steerben @thomasv314 Would one of you be able to sign off on this?

steerben · 2020-06-30T20:08:01Z

Fine for me. :)
Thanks for the update.

Raffo · 2020-07-01T07:44:47Z

/approve
/lgtm

k8s-ci-robot · 2020-07-01T07:44:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Raffo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 28, 2020

k8s-ci-robot requested review from hjacobs and njuettner May 28, 2020 16:59

tariq1890 force-pushed the add_vs branch from cfa76c1 to 943f61a Compare May 28, 2020 17:00

tariq1890 force-pushed the add_vs branch 2 times, most recently from 9b2e3dc to 0176a7a Compare May 29, 2020 17:48

thomasv314 mentioned this pull request Jun 4, 2020

[stable/external-dns] Add the ability for external-dns to manage records with Istio Virtual… helm/charts#22669

Closed

4 tasks

tariq1890 force-pushed the add_vs branch from 0176a7a to 8a9b2eb Compare June 7, 2020 06:46

tariq1890 force-pushed the add_vs branch from 8a9b2eb to 73e38ae Compare June 7, 2020 06:56

tariq1890 mentioned this pull request Jun 7, 2020

Add istio-virtualservice source #1358

Closed

2 tasks

Raffo reviewed Jun 14, 2020

View reviewed changes

tariq1890 force-pushed the add_vs branch from 73e38ae to 09862c7 Compare June 24, 2020 15:59

tariq1890 force-pushed the add_vs branch from 09862c7 to 59981b2 Compare June 24, 2020 16:35

add new source for istio virtual services

c2788b2

Co-authored-by: Alfred Krohmer <alfred.krohmer@logmein.com> Co-authored-by: Jonas-Taha El Sesiy <github@elsesiy.com>

tariq1890 force-pushed the add_vs branch from 59981b2 to c2788b2 Compare June 29, 2020 20:20

k8s-ci-robot assigned Raffo Jul 1, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020

k8s-ci-robot merged commit a11414f into kubernetes-sigs:master Jul 1, 2020

tariq1890 deleted the add_vs branch August 10, 2020 20:21

tariq1890 mentioned this pull request Aug 18, 2020

add event handler for istio gateway and virtualservice source #1728

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add new source for istio virtual services #1607

add new source for istio virtual services #1607

tariq1890 commented May 28, 2020 •

edited

Loading

tariq1890 commented May 29, 2020

elsesiy commented May 29, 2020 •

edited

Loading

sheerun commented May 29, 2020

tariq1890 commented May 29, 2020

elsesiy commented May 29, 2020

tariq1890 commented May 29, 2020

elsesiy commented May 29, 2020 •

edited

Loading

tariq1890 commented Jun 7, 2020

tariq1890 commented Jun 7, 2020

thomasv314 commented Jun 8, 2020

tariq1890 commented Jun 9, 2020

tariq1890 commented Jun 10, 2020

Raffo left a comment

Raffo Jun 14, 2020

tariq1890 Jun 24, 2020

Raffo Jun 28, 2020

Raffo commented Jun 24, 2020

tariq1890 commented Jun 24, 2020

tariq1890 commented Jun 27, 2020

tariq1890 commented Jun 27, 2020

Raffo commented Jun 28, 2020

steerben commented Jun 29, 2020 •

edited

Loading

steerben commented Jun 29, 2020

tariq1890 commented Jun 29, 2020 •

edited

Loading

tariq1890 commented Jun 29, 2020

steerben commented Jun 30, 2020

Raffo commented Jul 1, 2020

k8s-ci-robot commented Jul 1, 2020

add new source for istio virtual services #1607

add new source for istio virtual services #1607

Conversation

tariq1890 commented May 28, 2020 • edited Loading

tariq1890 commented May 29, 2020

elsesiy commented May 29, 2020 • edited Loading

sheerun commented May 29, 2020

tariq1890 commented May 29, 2020

elsesiy commented May 29, 2020

tariq1890 commented May 29, 2020

elsesiy commented May 29, 2020 • edited Loading

tariq1890 commented Jun 7, 2020

tariq1890 commented Jun 7, 2020

thomasv314 commented Jun 8, 2020

tariq1890 commented Jun 9, 2020

tariq1890 commented Jun 10, 2020

Raffo left a comment

Choose a reason for hiding this comment

Raffo Jun 14, 2020

Choose a reason for hiding this comment

tariq1890 Jun 24, 2020

Choose a reason for hiding this comment

Raffo Jun 28, 2020

Choose a reason for hiding this comment

Raffo commented Jun 24, 2020

tariq1890 commented Jun 24, 2020

tariq1890 commented Jun 27, 2020

tariq1890 commented Jun 27, 2020

Raffo commented Jun 28, 2020

steerben commented Jun 29, 2020 • edited Loading

steerben commented Jun 29, 2020

tariq1890 commented Jun 29, 2020 • edited Loading

tariq1890 commented Jun 29, 2020

steerben commented Jun 30, 2020

Raffo commented Jul 1, 2020

k8s-ci-robot commented Jul 1, 2020

tariq1890 commented May 28, 2020 •

edited

Loading

elsesiy commented May 29, 2020 •

edited

Loading

elsesiy commented May 29, 2020 •

edited

Loading

steerben commented Jun 29, 2020 •

edited

Loading

tariq1890 commented Jun 29, 2020 •

edited

Loading