-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #452 from helmholtz-analytics/coquelin77-patch-1
Update pull_request_template.md
- Loading branch information
Showing
1 changed file
with
14 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,29 @@ | ||
## Description | ||
|
||
Please include a summary of the change and which issue/s is/are fixed. | ||
Include a summary of the change/s. | ||
Please also include relevant motivation and context. List any dependencies that are required for this change. | ||
|
||
Fixes: # | ||
Issue/s resolved: # | ||
|
||
Changes proposed: | ||
## Changes proposed: | ||
- | ||
- | ||
- | ||
- | ||
|
||
## Type of change | ||
|
||
Select relevant options. | ||
Remove irrelevant options: | ||
- Bug fix (non-breaking change which fixes an issue) | ||
- New feature (non-breaking change which adds functionality) | ||
- Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
- Documentation update | ||
|
||
- [ ] Bug fix (non-breaking change which fixes an issue) | ||
- [ ] New feature (non-breaking change which adds functionality) | ||
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
- [ ] Documentation update | ||
## Due Diligence | ||
|
||
Are all split configurations tested and accounted for? | ||
- [ ] yes | ||
- [ ] no | ||
- [ ] All split configurations tested | ||
- [ ] Multiple dtypes tested in relavent functions | ||
- [ ] Documentation updated (if needed) | ||
|
||
Does this change require a documentation update outside of the changes proposed? | ||
- [ ] yes | ||
- [ ] no | ||
|
||
Does this change modify the behaviour of other functions? | ||
- [ ] yes | ||
- [ ] no | ||
|
||
Are there code practices which require justification? | ||
- [ ] yes | ||
- [ ] no | ||
#### Does this change modify the behaviour of other functions? If so, which? | ||
yes / no |