Skip to content

Commit

Permalink
Merge pull request #452 from helmholtz-analytics/coquelin77-patch-1
Browse files Browse the repository at this point in the history
Update pull_request_template.md
  • Loading branch information
coquelin77 authored Jan 20, 2020
2 parents 51684d5 + 60fac43 commit 002ea9b
Showing 1 changed file with 14 additions and 22 deletions.
36 changes: 14 additions & 22 deletions docs/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,29 @@
## Description

Please include a summary of the change and which issue/s is/are fixed.
Include a summary of the change/s.
Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #
Issue/s resolved: #

Changes proposed:
## Changes proposed:
-
-
-
-

## Type of change

Select relevant options.
Remove irrelevant options:
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- Documentation update

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation update
## Due Diligence

Are all split configurations tested and accounted for?
- [ ] yes
- [ ] no
- [ ] All split configurations tested
- [ ] Multiple dtypes tested in relavent functions
- [ ] Documentation updated (if needed)

Does this change require a documentation update outside of the changes proposed?
- [ ] yes
- [ ] no

Does this change modify the behaviour of other functions?
- [ ] yes
- [ ] no

Are there code practices which require justification?
- [ ] yes
- [ ] no
#### Does this change modify the behaviour of other functions? If so, which?
yes / no

0 comments on commit 002ea9b

Please sign in to comment.