Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #452

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Update pull_request_template.md #452

merged 2 commits into from
Jan 20, 2020

Conversation

coquelin77
Copy link
Member

Description

Please include a summary of the change and which issue/s is/are fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #

Changes proposed:

Type of change

Select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Are all split configurations tested and accounted for?

  • yes
  • no

Does this change require a documentation update outside of the changes proposed?

  • yes
  • no

Does this change modify the behaviour of other functions?

  • yes
  • no

Are there code practices which require justification?

  • yes
  • no

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #452 into master will decrease coverage by 0.06%.
The diff coverage is 94.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
- Coverage   96.74%   96.68%   -0.07%     
==========================================
  Files          57       57              
  Lines       12307    12134     -173     
==========================================
- Hits        11907    11732     -175     
- Misses        400      402       +2
Impacted Files Coverage Δ
heat/core/tests/test_statistics.py 99.27% <100%> (-0.07%) ⬇️
heat/core/statistics.py 97.13% <91.93%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a345464...60fac43. Read the comment docs.

Copy link
Member

@bhagemeier bhagemeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a little more concise than the previous version. OK for me.

@coquelin77 coquelin77 merged commit 002ea9b into master Jan 20, 2020
@coquelin77 coquelin77 deleted the coquelin77-patch-1 branch January 20, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants